You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Unix-only pages should each say "Availability: Unix" #106861
Additionally, some of them actually already have an availability directive (via the wasm_notavail.rst include) that only lists as its contents not Emscripten, not WASI that implies it is available on other platforms. Unfortunately, the rather crude nature of that currently being done as an include makes it not possible to add any other qualifiers to the availability directive.
Add the appropriate logic to the directive itself (as its already a custom directive, enforces a constrained syntax and parses platform names) to insert the appropriate descriptive content if not Emscripten, not WASI are listed as platforms. To avoid further overloading the directive code with bespoke content and special-casing, and make this easy to configure in the future, this would be stored in the conf.py, along with the known platform names, as a mapping from platform names to standard description content to inject.
To note, this would also easily allow for auto-cross-referencing platforms named in directives to, e.g. sections describing their current status in Python, configured via the same mechanism. In fact, this could preclude the need for custom description injects at all, the existing usage just slightly elaborates on the base directive content and directs the users to such a section for more information.
Activity
CAM-Gerlach commentedon Jul 18, 2023
Additionally, some of them actually already have an
availabilitydirective (via thewasm_notavail.rstinclude) that only lists as its contentsnot Emscripten, not WASIthat implies it is available on other platforms. Unfortunately, the rather crude nature of that currently being done as an include makes it not possible to add any other qualifiers to theavailabilitydirective.Add the appropriate logic to the directive itself (as its already a custom directive, enforces a constrained syntax and parses platform names) to insert the appropriate descriptive content if
not Emscripten, not WASIare listed as platforms. To avoid further overloading the directive code with bespoke content and special-casing, and make this easy to configure in the future, this would be stored in theconf.py, along with the known platform names, as a mapping from platform names to standard description content to inject.To note, this would also easily allow for auto-cross-referencing platforms named in directives to, e.g. sections describing their current status in Python, configured via the same mechanism. In fact, this could preclude the need for custom
descriptioninjects at all, the existing usage just slightly elaborates on the base directive content and directs the users to such a section for more information.CAM-Gerlach commentedon Jul 18, 2023
I opened #106867 to cover the directive improvements discussed above that are required by this issue.
pythongh-106861: add availability on unix-only pages
pythongh-106861: add availability on unix-only pages
pythongh-106861: add availability on unix-only pages
gh-106861: Docs: Add availability directives to all Unix-only modules (…
pythongh-106861: Docs: Add availability directives to all Unix-only m…
pythongh-106861: Docs: Add availability directives to all Unix-only m…
hugovk commentedon Oct 31, 2023
#108975 has been merged and backports will be soon. Thanks!
[3.12] gh-106861: Docs: Add availability directives to all Unix-only …
[3.11] gh-106861: Docs: Add availability directives to all Unix-only …
pythongh-106861: Docs: Add availability directives to all Unix-only m…
pythongh-106861: Docs: Add availability directives to all Unix-only m…
pythongh-106861: Docs: Add availability directives to all Unix-only m…