Skip to content

edit zipfile documentation for consistency #102190

Closed

Description

@dlwrnc

Documentation

there are a few methods in zipfile where args are not explained in the method docstring for public methods. e.g., pwd arg is not explained here: https://github.com/python/cpython/blob/main/Lib/zipfile/__init__.py#L1520, but is documented in a few other public methods.

it's possible to find out what pwd is with a little bit of digging, but it would be helpful to have it defined in the method. it seems like pwd is the most consistently undefined one across zipfile, but i'd be happy to look for other ones as well.

volunteering myself to take care of this work, will open a PR shortly.

Linked PRs

Activity

  1. dlwrnc commented on Mar 21, 2023

    @dlwrnc
    ContributorAuthor

    one-month ping on this. :)

  2. dlwrnc commented on Mar 31, 2024

    @dlwrnc
    ContributorAuthor

    ping on this issue <3. I forgot about it and then got bit again by it this week.

  3. added a commit that references this issue on Mar 31, 2024
  4. added a commit that references this issue on Mar 31, 2024
  5. erlend-aasland commented on Mar 31, 2024

    @erlend-aasland
    Contributor

    Are there more actionable items left, or can we close this?

  6. dlwrnc commented on Mar 31, 2024

    @dlwrnc
    ContributorAuthor

    good to close 👍 I'll probably open another issue at some point to tidy up the rest of the zipfile docstrings, but that's out of the scope of this one.

  7. added a commit that references this issue on Apr 1, 2024
  8. added a commit that references this issue on Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    docsDocumentation in the Doc dir

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions