Print out commit message after continuing#109
Merged
Conversation
brettcannon
reviewed
Jun 5, 2017
| self.cleanup_branch(cherry_pick_branch) | ||
|
|
||
| click.echo("\nBackport PR:\n") | ||
| click.echo(updated_commit_message) |
Member
There was a problem hiding this comment.
So is this printing out the title, message body, or both? The previous line is ambiguous without context so I don't know what to expect to see in the eventual output.
Member
Author
There was a problem hiding this comment.
This prints out the title, prefixed with [X.Y], message body, and cherry picked from .. message
Example output when backporting PR python/cpython#879:
[3.6] bpo-29931 fix __lt__ check in ipaddress.ip_interface for both v4 and v6. (GH-879)
the original logic was just comparing the network address
but this is wrong because if the network address is equal then
we need to compare the ip address for breaking the tie
add more ip_interface comparison tests.
(cherry picked from commit 7bd8d3e794782582a4ad1c9749424fff86802c3e)
I recorded an asciicast: https://asciinema.org/a/123496
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temp fix for #108