Skip to content

Added new build workers for Windows#234

Merged
pablogsal merged 2 commits into
python:masterfrom
jkloth:master
Apr 12, 2021
Merged

Added new build workers for Windows#234
pablogsal merged 2 commits into
python:masterfrom
jkloth:master

Conversation

@jkloth
Copy link
Copy Markdown
Contributor

@jkloth jkloth commented Apr 10, 2021

No description provided.

@jkloth
Copy link
Copy Markdown
Contributor Author

jkloth commented Apr 12, 2021

Adding recent contributors and buildbot watchers @pablogsal @vstinner

Note that I have already switched the hardware for my main worker, but have left the newly added (renamed) worker offline so as to not flood the build master with connection requests.

@pablogsal
Copy link
Copy Markdown
Member

@jkloth Do you have already keys(passwords) for those builders I assume, no?

@jkloth
Copy link
Copy Markdown
Contributor Author

jkloth commented Apr 12, 2021

I believe that the password stays the same for all workers from the same owner, given the format '{owner}-{worker}' for worker naming.

@pablogsal
Copy link
Copy Markdown
Member

I believe that the password stays the same for all workers from the same owner, given the format '{owner}-{worker}' for worker naming.

Yup, but some owners have several ones for different workers so I just wanted to check :)

@pablogsal pablogsal merged commit e7d8fd1 into python:master Apr 12, 2021
@Fidget-Spinner
Copy link
Copy Markdown
Member

Fidget-Spinner commented Apr 13, 2021

I'm not sure if this is the correct place to comment (sorry if it isn't, I'm not too familiar with the buildbots in CPython), but recently any grammar keyword changes in the new worker have failed to compile. For example: https://buildbot.python.org/all/#/builders/596/builds/2/steps/2/logs/stdio

It seems that the regen grammar script needs >= Python 3.8 as it's using :=, while the worker detects and runs py -3.7 on the script.

This wasn't triggered earlier because that specific part of the script won't run if no keyword changes are detected.

@pablogsal
Copy link
Copy Markdown
Member

It seems that the regen grammar script needs >= Python 3.8 as it's using :=, while the worker detects and runs py -3.7 on the script.

@jkloth Could you adapt your buildbot so Python3.8 is used for regenerating files as is done in the UNIX Makefile?

@jkloth
Copy link
Copy Markdown
Contributor Author

jkloth commented Apr 13, 2021

This worker has both 3.9 and 3.7 (both 64-bit) installed. Running py -0p from the terminal shows that 3.9 is also the default. That would mean that there is a bug in the build scripts for choosing the incompatible python installation.

@pablogsal
Copy link
Copy Markdown
Member

This worker has both 3.9 and 3.7 (both 64-bit) installed. Running py -0p from the terminal shows that 3.9 is also the default. That would mean that there is a bug in the build scripts for choosing the incompatible python installation.

Hummmm, interesting. But we have Windows builders in the CI and those are ok with it. In fact, this seems to be the only buildbot that is failing with this.

@Fidget-Spinner
Copy link
Copy Markdown
Member

Fidget-Spinner commented Apr 13, 2021

I created the draft PR python/cpython#25389 to see if it fixes this.

Edit:

Hummmm, interesting. But we have Windows builders in the CI and those are ok with it. In fact, this seems to be the only buildbot that is failing with this.

It's possible they have only Python 3.8 installed, which would pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants