Deprecate @pytest_asyncio.fixture for synchronous fixtures#1473
Open
SaInekK wants to merge 1 commit into
Open
Conversation
Widen _R TypeVar (removing the Awaitable|AsyncIterator bound) so that @pytest_asyncio.fixture can be applied to synchronous functions without a type error. Emit PytestDeprecationWarning at decoration time when the decorated function is not a coroutine or async generator function. The internal synchronizer wrapper in pytest_fixture_setup bypasses _make_asyncio_fixture_function to avoid a false-positive warning. Closes pytest-dev#1090
6a90da5 to
03c9ab8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1473 +/- ##
==========================================
+ Coverage 94.50% 94.54% +0.03%
==========================================
Files 2 2
Lines 510 513 +3
Branches 62 63 +1
==========================================
+ Hits 482 485 +3
Misses 22 22
Partials 6 6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
@pytest_asyncio.fixtureon a synchronous function is a user mistake — synchronous fixtures should use@pytest.fixture. Previously this silently succeeded, making the error hard to diagnose.This PR:
_R = TypeVar("_R")(removes theAwaitable | AsyncIteratorbound) so applying@pytest_asyncio.fixtureto a sync function no longer raises a type error before the warning fires.PytestDeprecationWarningat decoration time when the decorated function is not a coroutine or async generator.Closes #1090