Do Not Truncate Crash Messages In Short Test Summary on CI#9933
Conversation
There was a problem hiding this comment.
Thanks a lot @sommersoft!
Left a few suggestions, please take a look.
Should this be mentioned in the docs, maybe as a note?
Not sure it is needed, but feel free to write a .. note:: at the end of that section if you like. 👍
nicoddemus
left a comment
There was a problem hiding this comment.
Thanks, looks great!
Feel free to add yourself to the AUTHORS file btw.
|
Fixed the merge conflicts (hopefully).
Maybe at some point. This was a tiny change, but I appreciate the sentiment. |
|
Thanks again @sommersoft ! |
|
Which version of pytest will this be in? |
The next feature release, i.e., 7.2. |
|
Which python version does it need? It seems it can work with 3.9. If I use python version 3.9 and install pytest version 7.2: |
|
@jainshilpi There has not been a 7.2 release yet, so that's correct - but not related to your Python version. See #10045. (For the record, the supported Python versions are documented here: Python version support. At the time of writing, 3.7+ is supported.) |
|
I see, thanks for the pointers. I suppose I'll have to wait till then? Or is there a quick fix to this issue of truncated messages at the end? |
|
You could maybe set |
|
Really appreciate you adding this fix! I'm new to pytest, but should "CI" and "BUILD_NUMBER" be added to the "Environment Variables" section of the reference? |
Good idea, created #10690 to track that. PRs are welcome! 😁 |
Fixes #9920
This skips crash message truncation, if a
CIenvironment variable is set and truthy.Should this be mentioned in the docs, maybe as a note? https://github.com/pytest-dev/pytest/blob/main/doc/en/how-to/output.rst#producing-a-detailed-summary-report
Thanks to blueyed for some hints in #5284.