Skip to content

Add tee-fd capture mode and capteefd fixtures #14432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FazeelUsmani wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Add tee-fd capture mode and capteefd fixtures #14432

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c6d0e31
Add tee-fd capture mode and capteefd fixtures
FazeelUsmani May 1, 2026
231fcfb
Add changelog entry for tee-fd capture
FazeelUsmani May 1, 2026
39babc1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 1, 2026
865cd75
Fix ruff and mypy errors
FazeelUsmani May 1, 2026
9ad759b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 1, 2026
f4b2928
Move queue import to module level
FazeelUsmani May 1, 2026
de6ed63
Add pragma no cover for platform-specific code
FazeelUsmani May 1, 2026
4f3c621
Add pragma no cover for platform-specific methods
FazeelUsmani May 1, 2026
b14c706
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 1, 2026
4bcc34d
Add coverage pragmas and capteefdbinary test
FazeelUsmani May 1, 2026
b770b9e
Add coverage pragmas and capteefdbinary test
FazeelUsmani May 1, 2026
bfe8186
Merge branch 'tee-fd-capture' of https://github.com/FazeelUsmani/pyte…
FazeelUsmani May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add pragma no cover for platform-specific code
  • Loading branch information
@FazeelUsmani
FazeelUsmani committed May 1, 2026
commit de6ed6381bc4a7881b5fd3140d8fce2950a451bb
8 changes: 4 additions & 4 deletions src/_pytest/capture.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,9 +682,9 @@ def _tee_thread(self) -> None:
Uses non-blocking reads with select/poll for proper synchronization.
Responds to snap requests by draining the pipe and signaling completion.
"""
if sys.platform == "win32":
if sys.platform == "win32": # pragma: no cover
self._tee_thread_windows()
else:
else: # pragma: no cover
self._tee_thread_unix()

def _tee_thread_unix(self) -> None:
Expand Down Expand Up @@ -837,7 +837,7 @@ def _request_snap_sync(self) -> None:
self._snap_requested.set()

# Wait for thread to acknowledge (with timeout)
if not self._snap_complete.wait(timeout=1.0):
if not self._snap_complete.wait(timeout=1.0): # pragma: no cover
warnings.warn(
f"FDCaptureTee snap sync for fd {self.targetfd} timed out. "
"Some captured output may be incomplete.",
Expand Down Expand Up @@ -883,7 +883,7 @@ def done(self) -> None:
# Wait for thread to finish processing all data
if self._thread is not None:
self._thread.join(timeout=5.0)
if self._thread.is_alive():
if self._thread.is_alive(): # pragma: no cover
warnings.warn(
f"FDCaptureTee thread for fd {self.targetfd} did not exit cleanly "
"within timeout. Some captured output may be lost.",
Expand Down
Loading