Correct the spelling of ArgSource.INVOCATION_DIR#11333
Conversation
| ARGS = enum.auto() | ||
| #: Invocation directory. | ||
| INCOVATION_DIR = enum.auto() | ||
| INVOCATION_DIR = enum.auto() |
There was a problem hiding this comment.
If there are backwards-compatibility concerns, we could also add an alias:
INCOVATION_DIR = INVOCATION_DIRThere was a problem hiding this comment.
Yes, we should add an alias, otherwise it'd be a breaking change.
Config.ArgsSource.INCOVATION_DIR remains as a backwards compatibility alias.
bluetech
left a comment
There was a problem hiding this comment.
Thanks (also for adding the tests)!
I'll add a note to the changelog that an alias remains.
|
Wouldn't it make sense to use a |
|
Deprecations == pain, IMO it's not worth it for something like an alias. |
I don't have a strong preference either way, but I'd be happy to implement this approach if it's more aligned with the project's norms. As an aside, the old (misspelled) symbol doesn't appear to have been used by any open source (on GitHub) code: https://github.com/search?q=INCOVATION_DIR+lang%3Apython&type=code ... but that is of course an incomplete view. |
This was spelled incorrectly when introduced in #9897.