Skip to content

Add explicit pyscript version to create and wrap cmd templates #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mchilvers merged 9 commits into from
Jan 11, 2023
Merged

Add explicit pyscript version to create and wrap cmd templates #67

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
17be948
add LATEST_PYSCRIPT_VERSION constant
fpliger Jan 11, 2023
e8b3a9e
add pyscript-version parameter to create cmd
fpliger Jan 11, 2023
9677b1e
add pyscript_version parameter on methods that create new app from te…
fpliger Jan 11, 2023
abf333f
add test for new create cmd version argument
fpliger Jan 11, 2023
24a932b
add test for create
fpliger Jan 11, 2023
594915c
add test for wrap cmd
fpliger Jan 11, 2023
acbd25b
add test for pyscript version when calling wrap with file instead of cmd
fpliger Jan 11, 2023
d94bedb
improve tests
fpliger Jan 11, 2023
b0a1d1c
fix typing error
fpliger Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test for pyscript version when calling wrap with file instead of cmd
  • Loading branch information
@fpliger
fpliger committed Jan 11, 2023
commit acbd25bcaf8376035bc5130a1fbe99bfe9b4117e
42 changes: 42 additions & 0 deletions tests/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,48 @@ def test_wrap_pyscript_version(
assert css_version_str in html_text


@pytest.mark.parametrize(
"version, expected_version",
[(None, LATEST_PYSCRIPT_VERSION), ("2022.9.1", "2022.9.1")],
)
def test_wrap_pyscript_version_file(
invoke_cli: CLIInvoker,
version: Optional[str],
expected_version: str,
tmp_path: Path,
) -> None:
command = 'print("Hello World!")'
input_file = tmp_path / "hello.py"
with input_file.open("w") as fp:
fp.write(command)

args = ["wrap", str(input_file), "-o", "output.html"]

if version is not None:
args.extend(["--pyscript-version", version])
result = invoke_cli(*args)
assert result.exit_code == 0

expected_html_path = tmp_path / "output.html"
assert expected_html_path.exists()

with expected_html_path.open() as fp:
html_text = fp.read()

assert f"<py-script>\n{command}\n</py-script>" in html_text

version_str = (
f'<script defer src="https://pyscript.net/releases/{expected_version}'
'/pyscript.js"></script>'
)
css_version_str = (
'<link rel="stylesheet" href="https://pyscript.net/releases/'
f'{expected_version}/pyscript.css"/>'
)
assert version_str in html_text
assert css_version_str in html_text


@pytest.mark.parametrize(
"create_args, expected_version",
[
Expand Down