Skip to content

Add LICENSE file and fix license in pyproject.toml#4

Merged
mattkram merged 2 commits intomainfrom
chore/license
May 5, 2022
Merged

Add LICENSE file and fix license in pyproject.toml#4
mattkram merged 2 commits intomainfrom
chore/license

Conversation

@mattkram
Copy link
Copy Markdown
Contributor

@mattkram mattkram commented May 5, 2022

Adds Apache 2.0 license file and specification in pyproject.toml.

pyproject.toml Outdated
[tool.poetry]
name = "pyscript-cli"
version = "0.2.0"
version = "0.3.0"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd arguably downgrade that version to 0.0.1 😆 .. Not that it matters too much right now. We should probably have a conversation on that and align at some point though.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking, semver doesn't allow 0 as a minor version. But I think this can be safely made as a patch.

This is one reason why having a separate repo for the CLI makes sense. We don't necessarily have to align the version numbers. Still, we should probably stay on 0.2.* and make lots of patches as-needed.

Unfortunately I jumped the gun a bit and rolling back to 0.1.* would break things unless I pulled a release from PyPI.

@fpliger
Copy link
Copy Markdown
Contributor

fpliger commented May 5, 2022

That's awesome! Thanks @mattkram !

@mattkram mattkram force-pushed the chore/license branch 2 times, most recently from cecae39 to 49ed0d7 Compare May 5, 2022 17:34
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 5, 2022

Codecov Report

Merging #4 (25d88d0) into main (a18764d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main        #4   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          145       145           
=========================================
  Hits           145       145           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a18764d...25d88d0. Read the comment docs.

@mattkram mattkram merged commit 5ab8137 into main May 5, 2022
@mattkram mattkram deleted the chore/license branch May 5, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants