Skip to content

Add a --default-file option to pyscript run #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jdw170000 wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Add a --default-file option to pyscript run #151

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4ca4659
add --default-file option to pyscript run
jdw170000 May 22, 2024
a47a244
add documentation for --default-file option in pyscript run
jdw170000 May 22, 2024
76c460f
update unit tests to include default_file kwarg
jdw170000 May 22, 2024
4c8a682
update comments on unit tests
jdw170000 May 22, 2024
c93aca7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 22, 2024
d35ed42
nits to appease precommit ci
jdw170000 May 22, 2024
cd7822b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 22, 2024
a467537
update default_file to use Optional[Path] type
jdw170000 May 22, 2024
6adaa40
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 22, 2024
39bcd55
more precommit ci nits
jdw170000 May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[pre-commit.ci] auto fixes from pre-commit.com hooks 
for more information, see https://pre-commit.ci
  • Loading branch information
@pre-commit-ci
pre-commit-ci[bot] committed May 22, 2024
commit 6adaa4076a1fc57ff9f278f9578b4120fc3b5083
9 changes: 4 additions & 5 deletions src/pyscript/plugins/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
from __future__ import annotations

from typing import Optional

import socketserver
import threading
import webbrowser
from functools import partial
from http.server import SimpleHTTPRequestHandler
from pathlib import Path
from typing import Optional

import typer

Expand All @@ -16,7 +15,7 @@

def get_folder_based_http_request_handler(
folder: Path,
default_file: Optional[Path] = None,
default_file: Path | None = None,
) -> type[SimpleHTTPRequestHandler]:
"""
Returns a FolderBasedHTTPRequestHandler with the specified directory.
Expand Down Expand Up @@ -71,7 +70,7 @@ def split_path_and_filename(path: Path) -> tuple[Path, str]:
return abs_path, ""


def start_server(path: Path, show: bool, port: int, default_file: Optional[Path] = None):
def start_server(path: Path, show: bool, port: int, default_file: Path | None = None):
"""
Creates a local server to run the app on the path and port specified.

Expand Down Expand Up @@ -125,7 +124,7 @@ def run(
),
view: bool = typer.Option(True, help="Open the app in web browser."),
port: int = typer.Option(8000, help="The port that the app will run on."),
default_file: Optional[Path] = typer.Option(
default_file: Path | None = typer.Option(
None, help="A default file to serve when a nonexistent file is accessed."
),
):
Expand Down