Skip to content

Rename offline zip #2413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntoll merged 4 commits into from
Nov 26, 2025
Merged

Rename offline zip #2413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d43e8b0
Add release calver to offline.zip
ntoll Nov 26, 2025
dfba1ce
Update release template for correct offline.zip filename.
ntoll Nov 26, 2025
655be1d
Update sed for global search/replace of _VERSION_
ntoll Nov 26, 2025
9a05ae9
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/publish-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,12 @@ jobs:
- name: build offline
run: npm run build:offline

- name: Rename offline.zip with version metadata
run: mv ./dist/offline.zip ./dist/offline_${{ github.ref_name }}.zip

- name: Generate index.html in snapshot
working-directory: .
run: sed -e 's#_PATH_#https://pyscript.net/releases/${{ github.ref_name }}/#' -e 's#_DOC_VERSION_#${{ github.ref_name }}#' -e 's#_TAG_VERSION_#/tag/${{ github.ref_name }}#' -e 's#_VERSION_#${{ github.ref_name }}#' ./public/index.html > ./core/dist/index.html
run: sed -e 's#_PATH_#https://pyscript.net/releases/${{ github.ref_name }}/#g' -e 's#_DOC_VERSION_#${{ github.ref_name }}#g' -e 's#_TAG_VERSION_#/tag/${{ github.ref_name }}#g' -e 's#_VERSION_#${{ github.ref_name }}#g' ./public/index.html > ./core/dist/index.html

- name: Generate release.tar from snapshot and put it in dist/
working-directory: .
Expand All @@ -71,7 +74,7 @@ jobs:
- name: Upload offline.zip to release
env:
GH_TOKEN: ${{ github.token }}
run: gh release upload ${{ github.ref_name }} ./dist/offline.zip
run: gh release upload ${{ github.ref_name }} ./dist/offline_${{ github.ref_name }}.zip

- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v5
Expand Down
9 changes: 5 additions & 4 deletions public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,8 @@ <h2>Files</h2>
<li><a href="core.js">core.js</a></li>
<li><a href="core.js.map">core.js.map</a></li>
<li>
<a href="offline.zip">offline.zip</a> (PyScript _VERSION_
zipped up for offline use)
<a href="offline__VERSION_.zip">offline__VERSION_.zip</a>
(PyScript _VERSION_ zipped up for offline use)
Copy link
Copy Markdown
Contributor

@WebReflection WebReflection Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks fine, it will result into just a space once visualized

Copy link
Copy Markdown
Member Author

@ntoll ntoll Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, again pre-commit hook mangled this. 🤦

</li>
</ul>
<div id="out"></div>
Expand Down Expand Up @@ -125,8 +125,9 @@ <h2>
d="M43.3,6h-1.6c-0.5,0-0.8,0.3-0.8,0.8V10c0,3.5-2.8,6.4-6.3,6.4H17.4c-3.5,0-6.3-2.9-6.3-6.4V6.8
c0-0.5-0.3-0.8-0.8-0.8H8.7C6.1,6,4,8.2,4,10.8v34.4C4,47.8,6.1,50,8.7,50h34.6c2.6,0,4.7-2.2,4.7-4.8V10.8C48,8.2,45.9,6,43.3,6z"
/>
</g></svg
></a>
</g>
</svg>
</a>
</h2>
<pre id="example">
&lt;!DOCTYPE html&gt;
Expand Down