Relax SharedArrayBuffer requirement for named workers#107
Closed
WebReflection wants to merge 1 commit intomainfrom
Closed
Relax SharedArrayBuffer requirement for named workers#107WebReflection wants to merge 1 commit intomainfrom
WebReflection wants to merge 1 commit intomainfrom
Conversation
Contributor
Author
|
This is actually fixed automatically by this #109 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR basically implements and test the idea behind this PyScript proposal:
pyscript/pyscript#2112
I am also warning in console when
sync_main_onlyis missing and the worker is named so that at least it'd be clear when we do fallback and when we don't.If
sync_main_onlyis explicitlytruethough, nothing happens. If it's explicitlyfalsean error is thrown as expectations cannot be met.