Add python_requires keywords to setup#631
Conversation
|
I don't think I would add the external stuff, I don't think it's generally useful and I think that we would want to avoid shipping that to people since it doesn't have much use. Totally on board with adding |
|
external_requires removed and 2 basic tests added. |
This should allow setuptools to write the metadata Requires-Python and Requires-External from PEP345 to the PKGINFO file
015d291 to
020771f
Compare
|
@jaraco any feedback ? |
|
Why is setuptools rejecting implementation of parts of an accepted PEP ? Should the PEP be edited? |
|
I haven't had a chance to review. I'll try to get to it soon. Ping me in a week if you haven't heard anything. |
|
@jayvdb Because it was never implemented, will likely be replaced in the future, and is a needless footgun. |
|
Looks good to me. Let's give it a go. |
|
Oh |
In the future, this will prevent installation on unsupported Python versions (pypa/setuptools#631).
This allows pip to figure out the last compatible version with a particular Python version before attempting to install. Support for this field was added to setuptools last year: pypa/setuptools#631
This allows pip to figure out the last compatible version with a particular Python version before attempting to install. Support for this field was added to setuptools last year: pypa/setuptools#631
) This allows pip to figure out the last compatible version with a particular Python version before attempting to install. Support for this field was added to setuptools last year: pypa/setuptools#631
This should allow setuptools to write the metadata Requires-Python and
Requires-External from PEP345 to the PKGINFO file
Looking for validation on the idea before improving it (docs and tests).
Are
python_requiresandexternal_requiresthe right keywords, or should they berequires_pythonandrequires_external?This would enable me to revive pypa/pip#3640 using
Requires-Pythoninfo.cc @dstufft