Skip to content

Preparation for updating wheel to 0.46+ - #5163

Merged
abravalheri merged 2 commits into
pypa:mainfrom
abravalheri:adequate-wheel
Jan 27, 2026
Merged

Preparation for updating wheel to 0.46+#5163
abravalheri merged 2 commits into
pypa:mainfrom
abravalheri:adequate-wheel

Conversation

@abravalheri

@abravalheri abravalheri commented Jan 23, 2026 •
edited by jaraco
Loading

Copy link
Copy Markdown
Contributor

Summary of changes

#5160 shows an unrelated error started happening when the CI picks up the latest version of wheel. In the CI we can see the following:

DeprecationWarning: The 'wheel.metadata' package has been made
private and should no longer be imported.
Please either copy the code or find an alternative library to
import it from, as this warning will be removed in a future 
version of 'wheel'.

My understanding is that this test function is in place to ensure the PKG-INFO/METADATA files generated by the latest setuptools are equivalent to the METADATA file generated by the now deprecated wheel.metadata module.

This test was particularly important during the transition period (when setuptools started to absorb some of the functions in wheel)... but it has been a while now, so we can consider the implementation to be stable. We should be able to remove the problematic test (or at least simplify it a lot) without risking too much.

Closes #5167

Pull Request Checklist

@abravalheri
abravalheri marked this pull request as ready for review January 23, 2026 15:52
@samhith123

samhith123 commented Jan 23, 2026

Copy link
Copy Markdown

@abravalheri You might wanna update the https://github.com/pypa/setuptools/blob/main/pyproject.toml to wheel>=0.46.0?

@abravalheri

abravalheri commented Jan 23, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @samhith123, that will be a separated PR. This is just the preparation before doing that.

@abravalheri abravalheri mentioned this pull request Jan 25, 2026
Closed
@Avasam

Avasam commented Jan 26, 2026

Copy link
Copy Markdown
Contributor

#5166 has updated vendored wheel to 0.46.3
If fixing the deprecation warning, let's not forget to also remove its exclusion from pytest.ini

@abravalheri

abravalheri commented Jan 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

After the rebase I can see this very annoying and uninformative CI error:

image

After downloading and unzipping the logs, I can see:

2026-01-26T18:02:51.9860000Z Evaluating test.if
2026-01-26T18:02:51.9860000Z Evaluating: success()
2026-01-26T18:02:51.9860000Z Result: true
2026-01-26T18:02:51.9890000Z Requested labels: windows-latest
2026-01-26T18:02:51.9890000Z Job defined at: pypa/setuptools/.github/workflows/main.yml@refs/pull/5163/merge
2026-01-26T18:02:51.9890000Z Waiting for a runner to pick up this job...
2026-01-26T18:02:52.2640000Z Job is about to start running on the hosted runner: GitHub Actions 1000276405
2026-01-26T18:02:52.2640000Z Job is waiting for a hosted runner to come online.

Which is still not informative...

@Avasam

Avasam commented Jan 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Edit: ah! GitHub status finally updated, there's a current issue: https://www.githubstatus.com/
image

Normally I see this kind of error when there's no runner available (large runner on an org where they're not available, typo'd runner, usage limit, etc.), but that doesn't make sense here with windows-latest on a public repo ...

One could try enabling debug logging: https://docs.github.com/en/actions/how-tos/monitor-workflows/enable-debug-logging

@abravalheri
abravalheri merged commit 32de647 into pypa:main Jan 27, 2026
31 of 44 checks passed
@abravalheri
abravalheri deleted the adequate-wheel branch January 27, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaraco jaraco jaraco approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

wheel.metadata is deprecated

4 participants

@abravalheri @samhith123 @Avasam @jaraco