Skip to content

Remove pipenv "state of project" caveat - #729

Merged
pradyunsg merged 4 commits into
pypa:masterfrom
mavaddat:patch-1
Jun 22, 2020
Merged

Remove pipenv "state of project" caveat#729
pradyunsg merged 4 commits into
pypa:masterfrom
mavaddat:patch-1

Conversation

@mavaddat

Copy link
Copy Markdown
Contributor

The pipenv team hit their April and May release targets, so the caveat about the seeming impasse of pipenv development no longer applies. However, it may benefit the user to know that the early access version of the package is available as pre-release in pip.

The pipenv team hit their April and May release targets, so the caveat about the seeming impasse of pipenv development no longer applies. However, it may benefit the user to know that the early access version of the package is available as pre-release in `pip`.
@pradyunsg

Copy link
Copy Markdown
Member

I think we should wait for a stable release prior to merging this.

@ncoghlan

Copy link
Copy Markdown
Member

It would be good to at least reword the caveat with a pointer to the pre-release, though - at the time I wrote it, even that wasn't out yet.

We're also past the worst of the release roadblocks now (prior to that first pre-release, things had atrophied to the point where even Dan couldn't readily push a new release to PyPI)

@webknjaz

Copy link
Copy Markdown
Member

+1 to reword, removing completely shouldn't be done until it's stable

@pradyunsg

pradyunsg commented May 27, 2020

Copy link
Copy Markdown
Member

@mavaddat Would you be willing to re-add the caveat, update the heading of the caveat to say June instead of April (we can wait a couple of days before merging) and reword a couple of sentences in the section, pointing to the pre-release that's been made already?

entirety of 2019 passing without a new release).

This means that in the near term, ``pipenv`` still suffers from several quirks
and performance problems without a clear timeline for resolution of those isses.

@pradyunsg pradyunsg May 27, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you do that, please also fix the "isses" typo. :)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that typo was actually what motivated me to contribute to the tutorial in the first place!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/me needs to start planting more typos into tutorials to motivate grammar-nazi

mavaddat added 2 commits May 27, 2020 21:21
I re-ordered the phrasing to give the reader a sense of the big picture first. Also, I attempted to clarify the language about library vs application development. However, I am not sure if I captured the spirit of what was intended by those words by the previous author.
I removed some redundant language.
@ncoghlan

Copy link
Copy Markdown
Member

Heh, naturally the release happens after we had decided to keep the caveat until then: https://pypi.org/project/pipenv/2020.5.28/ :)

@pradyunsg

Copy link
Copy Markdown
Member

Another green tick, and I'll be happy to merge. :)

@pradyunsg pradyunsg changed the title Remove April caveat, add pre-release notice Remove pipenv "state of project" caveat Jun 22, 2020
@pradyunsg
pradyunsg merged commit 19bc7ae into pypa:master Jun 22, 2020
@pradyunsg

Copy link
Copy Markdown
Member

Thanks @mavaddat! ^>^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants