Skip to content

Normalize case and make small changes in the reference implementation for dependency groups resolution#2045

Open
jonathandung wants to merge 1 commit into
pypa:mainfrom
jonathandung:main
Open

Normalize case and make small changes in the reference implementation for dependency groups resolution#2045
jonathandung wants to merge 1 commit into
pypa:mainfrom
jonathandung:main

Conversation

@jonathandung
Copy link
Copy Markdown

@jonathandung jonathandung commented May 12, 2026 •
edited
Loading 

raise TypeError("Dependency Groups table is not a dict")

->

raise TypeError("Dependency groups table is not a dict")
dependency_groups_raw = pyproject["dependency-groups"]
dependency_groups = _normalize_group_names(dependency_groups_raw)
print("\n".join(resolve(pyproject["dependency-groups"], sys.argv[1])))

->

dependency_groups_raw = pyproject["dependency-groups"]
dependency_groups = _normalize_group_names(dependency_groups_raw)
print("\n".join(resolve(dependency_groups_raw, sys.argv[1])))

📚 Documentation preview 📚: https://python-packaging-user-guide--2045.org.readthedocs.build/en/2045/

@webknjaz
Copy link
Copy Markdown
Member

webknjaz commented May 12, 2026

@jonathandung motivation? Justification?

cc @sirosen

@jonathandung
Copy link
Copy Markdown
Author

jonathandung commented May 12, 2026

For the first one, I notice that the last commit to this file 1700f85 changed dependency groups to lowercase where suitable, and I think this qualifies. For the second, it is simply strange to me that pyproject["dependency-groups"] was used rather than dependency_groups_raw which had just been defined as exactly that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonathandung @webknjaz