Skip to content

Create a discussion on versioning - #1455

Merged
webknjaz merged 9 commits into
pypa:mainfrom
jeanas:versioning
Feb 9, 2024
Merged

Create a discussion on versioning#1455
webknjaz merged 9 commits into
pypa:mainfrom
jeanas:versioning

Conversation

@jeanas

@jeanas jeanas commented Dec 17, 2023

Copy link
Copy Markdown
Contributor

Move content on versioning schemes from
distributing-packages-using-setuptools.rst to a new discussion on versioning, and update it.

This is the continuation of #1450.


📚 Documentation preview 📚: https://python-packaging-user-guide--1455.org.readthedocs.build/en/1455/discussions/versioning/

Move content on versioning schemes from
distributing-packages-using-setuptools.rst to a new discussion on
versioning, and update it.
@webknjaz
webknjaz self-requested a review December 17, 2023 14:26
@chrysle

chrysle commented Dec 17, 2023

Copy link
Copy Markdown
Contributor

Looks good, thanks! Probably mention a few projects that comply with the different versioning systems?

Comment thread source/discussions/versioning.rst Outdated
Comment thread source/discussions/versioning.rst Outdated
Comment thread source/discussions/versioning.rst Outdated
Comment thread source/discussions/versioning.rst Outdated
Comment thread source/discussions/versioning.rst Outdated
Comment thread source/discussions/versioning.rst Outdated
Comment thread source/discussions/versioning.rst
Comment thread source/discussions/versioning.rst Outdated
Comment thread source/guides/distributing-packages-using-setuptools.rst
Comment thread source/discussions/index.rst
@webknjaz

Copy link
Copy Markdown
Member

@jeanas the first round of review complete.

@jeanas

jeanas commented Dec 17, 2023

Copy link
Copy Markdown
Contributor Author

Looks good, thanks! Probably mention a few projects that comply with the different versioning systems?

Good idea; done. (I've used Sphinx, NumPy and pip.)

@jeanas

jeanas commented Dec 17, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for the detailed comments! I've revised much of the page, please take another look.

@chrysle

chrysle commented Dec 18, 2023

Copy link
Copy Markdown
Contributor

Could you add an own paragraph for ZeroVer?

@jeanas

jeanas commented Dec 18, 2023

Copy link
Copy Markdown
Contributor Author

Could you add an own paragraph for ZeroVer?

It's a satire, not a serious thing :)

@chrysle

chrysle commented Dec 18, 2023

Copy link
Copy Markdown
Contributor

I know, it would be to warn users. Maybe that's stupid.

@sinoroc

This comment was marked as off-topic.

@jeanas

jeanas commented Dec 18, 2023

Copy link
Copy Markdown
Contributor Author

@sinoroc Sorry, I don't understand your comment at all. What “things” are less clear-cut in the new document?

@sinoroc

This comment was marked as off-topic.

@webknjaz

Copy link
Copy Markdown
Member

I wonder whether there is a risk people come to complain because we "bless" things that they don't like

That's literally the story of the Python Packaging in the nutshell 😂

@webknjaz

Copy link
Copy Markdown
Member

I think adding a 0ver remark might be fun, just don't pass judgement..

@jeanas

jeanas commented Dec 20, 2023

Copy link
Copy Markdown
Contributor Author
  • Added references to blog posts on SemVer's weaknesses
  • Added link to https://0ver.org

I think the only unresolved issue right now is #1455 (comment)

Comment thread source/discussions/versioning.rst Outdated
Comment thread source/discussions/versioning.rst
Comment thread source/discussions/versioning.rst Outdated
Comment thread source/discussions/versioning.rst Outdated
Comment thread source/discussions/versioning.rst Outdated
Comment thread source/discussions/versioning.rst
Comment thread source/discussions/versioning.rst Outdated
Comment thread source/discussions/versioning.rst
@webknjaz

Copy link
Copy Markdown
Member

@jeanas I stumbled upon an article by Seth. Maybe it could be linked from somewhere too: https://sethmlarson.dev/pep-440.

Comment thread source/discussions/versioning.rst
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
@jeanas

jeanas commented Feb 7, 2024

Copy link
Copy Markdown
Contributor Author

@webknjaz I've addressed the latest review.

@webknjaz
webknjaz enabled auto-merge February 9, 2024 11:30

@webknjaz webknjaz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@webknjaz
webknjaz added this pull request to the merge queue Feb 9, 2024
Merged via the queue into pypa:main with commit 8add7c5 Feb 9, 2024
@jeanas
jeanas deleted the versioning branch February 9, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants