Skip to content

Add discussion "Distribution package vs. import package" - #1426

Merged
webknjaz merged 14 commits into
pypa:mainfrom
jeanas:distribution-vs-import-package
Dec 17, 2023
Merged

Add discussion "Distribution package vs. import package"#1426
webknjaz merged 14 commits into
pypa:mainfrom
jeanas:distribution-vs-import-package

Conversation

@jeanas

@jeanas jeanas commented Dec 1, 2023 •
edited by webknjaz
Loading

Copy link
Copy Markdown
Contributor

sinoroc
sinoroc reviewed Dec 1, 2023
View reviewed changes
Comment thread source/discussions/distribution-package-vs-import-package.rst Outdated
sinoroc
sinoroc reviewed Dec 1, 2023
View reviewed changes
Comment thread source/discussions/distribution-package-vs-import-package.rst Outdated
@jeanas @sinoroc
Update source/discussions/distribution-package-vs-import-package.rst
176f956 
Co-authored-by: sinoroc <5529267+sinoroc@users.noreply.github.com>
jeanas
jeanas commented Dec 1, 2023
View reviewed changes
Comment thread source/discussions/distribution-package-vs-import-package.rst Outdated
@LLyaudet LLyaudet mentioned this pull request Dec 1, 2023
Open
@willingc willingc added the diataxis: explanation Understanding oriented discussion (https://diataxis.fr/explanation/) label Dec 1, 2023
webknjaz
webknjaz reviewed Dec 3, 2023
View reviewed changes
Comment thread source/discussions/distribution-package-vs-import-package.rst
webknjaz
webknjaz reviewed Dec 3, 2023
View reviewed changes
Comment thread source/discussions/distribution-package-vs-import-package.rst
webknjaz
webknjaz reviewed Dec 3, 2023
View reviewed changes
Comment thread source/discussions/distribution-package-vs-import-package.rst
webknjaz
webknjaz reviewed Dec 3, 2023
View reviewed changes
Comment thread source/discussions/distribution-package-vs-import-package.rst Outdated
webknjaz
webknjaz reviewed Dec 3, 2023
View reviewed changes
Comment thread source/discussions/distribution-package-vs-import-package.rst Outdated
webknjaz
webknjaz reviewed Dec 3, 2023
View reviewed changes
Comment thread source/discussions/distribution-package-vs-import-package.rst
webknjaz
webknjaz reviewed Dec 3, 2023
View reviewed changes
Comment thread source/discussions/distribution-package-vs-import-package.rst Outdated
webknjaz
webknjaz reviewed Dec 3, 2023
View reviewed changes
Comment thread source/discussions/distribution-package-vs-import-package.rst
@webknjaz webknjaz mentioned this pull request Dec 3, 2023
Merged
@jeanas jeanas mentioned this pull request Dec 13, 2023
Merged
@jeanas

jeanas commented Dec 14, 2023

Copy link
Copy Markdown
Contributor Author

I've tried to address all comments. @webknjaz Could you take another look when you have a chance?

webknjaz
webknjaz reviewed Dec 16, 2023
View reviewed changes
Comment thread source/discussions/distribution-package-vs-import-package.rst Outdated
webknjaz
webknjaz reviewed Dec 16, 2023
View reviewed changes
Comment thread source/discussions/distribution-package-vs-import-package.rst Outdated
webknjaz
webknjaz reviewed Dec 16, 2023
View reviewed changes
Comment thread source/discussions/distribution-package-vs-import-package.rst Outdated
jeanas and others added 2 commits December 16, 2023 08:26
@jeanas @webknjaz
The PyPI
d4164d2 
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
@jeanas
Python software -> Python libraries and tools
62273fe
jeanas
jeanas commented Dec 16, 2023
View reviewed changes
Comment thread source/discussions/distribution-package-vs-import-package.rst Outdated
jeanas
jeanas commented Dec 16, 2023
View reviewed changes
Comment thread source/discussions/distribution-package-vs-import-package.rst
jeanas
jeanas commented Dec 16, 2023
View reviewed changes
Comment thread source/discussions/distribution-package-vs-import-package.rst Outdated
jeanas
jeanas commented Dec 16, 2023
View reviewed changes
Comment thread source/discussions/distribution-package-vs-import-package.rst
jeanas
jeanas commented Dec 16, 2023
View reviewed changes
Comment thread source/discussions/distribution-package-vs-import-package.rst Outdated
jeanas
jeanas commented Dec 16, 2023
View reviewed changes
Comment thread source/discussions/distribution-package-vs-import-package.rst Outdated
jeanas
jeanas commented Dec 16, 2023
View reviewed changes
Comment thread source/discussions/distribution-package-vs-import-package.rst Outdated
webknjaz
webknjaz approved these changes Dec 17, 2023
View reviewed changes

@webknjaz webknjaz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant! Thank you for seeing this through!

@webknjaz
webknjaz added this pull request to the merge queue Dec 17, 2023
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Dec 17, 2023
@webknjaz
webknjaz added this pull request to the merge queue Dec 17, 2023
Merged via the queue into pypa:main with commit 84b5491 Dec 17, 2023
@jeanas
jeanas deleted the distribution-vs-import-package branch December 17, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willingc willingc willingc left review comments
@woodruffw woodruffw woodruffw left review comments
@webknjaz webknjaz webknjaz approved these changes
+2 more reviewers
@sethmlarson sethmlarson sethmlarson left review comments
@sinoroc sinoroc sinoroc approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

diataxis: explanation Understanding oriented discussion (https://diataxis.fr/explanation/)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a discussion on distribution packages vs. import packages

6 participants

@jeanas @webknjaz @willingc @woodruffw @sinoroc @sethmlarson