Skip to content

Add page "How to modernize a setup.py project?" - #1371

Merged
willingc merged 1 commit into
pypa:mainfrom
sinoroc:add-modernize-setup-py-project
Nov 11, 2023
Merged

Add page "How to modernize a setup.py project?"#1371
willingc merged 1 commit into
pypa:mainfrom
sinoroc:add-modernize-setup-py-project

Conversation

@sinoroc

@sinoroc sinoroc commented Nov 8, 2023

Copy link
Copy Markdown
Contributor

This is meant as a starting point. There is much more to say, and that can be said in follow-up pull requests.

Preview (but there were some small modifications on other pages as well, mainly links):

GitHub: refs #1334

@abravalheri abravalheri left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for working on this @sinoroc .

Comment thread source/guides/modernize-setup-py-project.rst Outdated
Comment thread source/guides/modernize-setup-py-project.rst Outdated
Comment thread source/guides/modernize-setup-py-project.rst
Comment thread source/guides/modernize-setup-py-project.rst Outdated
Comment thread source/guides/modernize-setup-py-project.rst Outdated
Comment thread source/guides/modernize-setup-py-project.rst Outdated
Comment thread source/guides/modernize-setup-py-project.rst Outdated
Comment thread source/guides/modernize-setup-py-project.rst Outdated
Comment thread source/guides/modernize-setup-py-project.rst Outdated
Comment thread source/guides/modernize-setup-py-project.rst Outdated
Comment thread source/guides/modernize-setup-py-project.rst

@willingc willingc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sinoroc for this improvement.

Comment thread source/guides/modernize-setup-py-project.rst
Comment thread source/guides/modernize-setup-py-project.rst Outdated
Comment thread source/guides/modernize-setup-py-project.rst Outdated
@sinoroc
sinoroc force-pushed the add-modernize-setup-py-project branch from 2f2a185 to fc17418 Compare November 9, 2023 20:41
@sinoroc
sinoroc force-pushed the add-modernize-setup-py-project branch from fc17418 to ae74041 Compare November 9, 2023 20:48

@willingc willingc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @sinoroc. Merging 😄

Comment thread source/guides/modernize-setup-py-project.rst
@willingc
willingc added this pull request to the merge queue Nov 11, 2023
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 11, 2023
@willingc
willingc added this pull request to the merge queue Nov 11, 2023
Merged via the queue into pypa:main with commit 9e32e17 Nov 11, 2023
@sinoroc

sinoroc commented Nov 11, 2023

Copy link
Copy Markdown
Contributor Author

Thanks all for the help! :)

@sinoroc
sinoroc deleted the add-modernize-setup-py-project branch November 11, 2023 12:25
Comment thread source/guides/modernize-setup-py-project.rst
===================================

A :term:`pyproject.toml` file is strongly recommended.
The presence of a :file:`pyproject.toml` file itself does not bring much. [#]_

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized that this prompts an inaccuracy in my understanding of the matter. See pypa/sampleproject#204 (comment).

@sinoroc I think this deserves a clarification. WDYT?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@webknjaz As I stated in the other discussion thread you linked, I do not understand the issue.

The important thing is the content of pyproject.toml, first of all the build-system table.

I have been told, and I have written it in this document, that simply having an empty pyproject.toml triggers the "build isolation" behavior for pip (and other installers?). But that should be anecdotal nowadays (I heard it caused some issues at some point in the early days of PEP 517), isn't build isolation the default behavior for pip nowadays?

I am not sure how to improve this paragraph. Maybe we could move the whole sentence further down below or maybe even to a side note / foot note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants