Skip to content

Add history section to externally managed environments spec. - #1308

Merged
webknjaz merged 1 commit into
pypa:mainfrom
serixscorpio:ext-managed-env-history
Oct 24, 2023
Merged

Add history section to externally managed environments spec.#1308
webknjaz merged 1 commit into
pypa:mainfrom
serixscorpio:ext-managed-env-history

Conversation

@serixscorpio

Copy link
Copy Markdown
Contributor

Addresses a small part of #1203 by adding a history section to the external management environments specification page.

@chrysle
chrysle enabled auto-merge October 23, 2023 13:56
@chrysle
chrysle added this pull request to the merge queue Oct 23, 2023
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 23, 2023
@webknjaz

Copy link
Copy Markdown
Member

@chrysle it seems like that breezy website needs to be added to linkcheck_ignore: https://lists.ubuntu.com/archives/bazaar/2023q4/076422.html.

Also, looking into the merge queues behavior: it looks like GH generates 2 events for it — one is merge_group and the other is push. This triggers 2 CI runs — https://github.com/pypa/packaging.python.org/actions/runs/6614309433 and https://github.com/pypa/packaging.python.org/actions/runs/6614309436 respectively.
We also have concurrency groups set up in a way that results into both events sharing the same group identifier. So the push CI workflow cancels the merge_group one. We may want to adjust this too...

@webknjaz

Copy link
Copy Markdown
Member

This https://github.blog/changelog/2022-08-18-merge-group-webhook-event-and-github-actions-workflow-trigger/ says

A push event is still sent when a merge group branch is created, and will trigger a GitHub Actions workflow. However, unlike a merge_group event, a push event does not include the target branch of the merge group.

Which kinda implies that we may need to drop the push event.

@webknjaz

Copy link
Copy Markdown
Member

So the push CI workflow cancels the merge_group one.

Ah, and that cancellation prompts GH to consider the CI run a failure, leading to destroying of the merge queue and unqueueing the PR.

webknjaz added a commit to webknjaz/packaging.python.org that referenced this pull request Oct 23, 2023
@webknjaz

Copy link
Copy Markdown
Member

@chrysle #1318 + #1319 should improve things.

@webknjaz
webknjaz added this pull request to the merge queue Oct 24, 2023
Merged via the queue into pypa:main with commit 0b20b77 Oct 24, 2023
@serixscorpio
serixscorpio deleted the ext-managed-env-history branch October 24, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants