Clarify that static metadata include external data that is referenced - #1232
Merged
Conversation
pfmoore
approved these changes
Mar 28, 2023
Member
|
Um, thanks 😉 I'd mentioned on Discourse that I planned to leave this a day or so before merging, but forgot to add a note here. Sorry, that's my bad, and no harm done. |
Member
|
Ah, I missed it but saw it after I merged. No worries though since reverts are cheap, we can still have people comment on this PR and I think it’s unlikely that someone considers this a show stopper thing. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E.g. the contents of
README.mdif referred to byreadmeis expected to not change unless thereadmefield itself is marked asdynamic.