No longer suggest wheel in build-requires for PEP 517 builds - #1050
Merged
Conversation
bhrutledge
approved these changes
Feb 27, 2022
bhrutledge
left a comment
Contributor
There was a problem hiding this comment.
Confirmed that removing wheel still builds a .whl. Just one optional question.
`"wheel"` is included with proper version by `get_requires_for_build_wheel` from PEP 517, and isn't required for making an sdist, and might not be required in the future at all (in which case setuptools will modify `get_requires_for_build_wheel`).
wheel in build-requires for PEP 517 builds
pradyunsg
enabled auto-merge (squash)
March 11, 2022 14:26
Contributor
|
@pradyunsg Spam 👆 I've seen these bots everywhere on GitHub lately. |
Merged
4 tasks
bluetech
added a commit
to bluetech/pytest
that referenced
this pull request
Aug 15, 2022
It's not required -- see pypa/packaging.python.org#1050
imgbot Bot
pushed a commit
to kkipngenokoech/pytest
that referenced
this pull request
Apr 18, 2026
It's not required -- see pypa/packaging.python.org#1050
imgbot Bot
pushed a commit
to kkipngenokoech/pytest
that referenced
this pull request
Apr 18, 2026
It's not required -- see pypa/packaging.python.org#1050
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"wheel"is included with proper version byget_requires_for_build_wheelfrom PEP 517, and isn't required for making an sdist, and might not be required in the future at all (in which case setuptools will modifyget_requires_for_build_wheel). It's available even in 40.8.This was probably my fault (actually, yes it was, git blame's to me). It is very common, so maybe we should mention wheel is not required? I'd go for simple, I think, but it's possible someone will try to add it again in a PR.