Skip to content

Ensure that wgpu is compatible both with imgui 1.6.0 and older#649

Merged
Korijn merged 2 commits intopygfx:mainfrom
hmaarrfk:two_versions_of_imgui
Dec 2, 2024
Merged

Ensure that wgpu is compatible both with imgui 1.6.0 and older#649
Korijn merged 2 commits intopygfx:mainfrom
hmaarrfk:two_versions_of_imgui

Conversation

@hmaarrfk
Copy link
Copy Markdown
Contributor

@hmaarrfk hmaarrfk commented Dec 1, 2024

Its a little frustrating to be forced to update for such a small thing, especially when trying to troubleshoot other compatibility issues.

@hmaarrfk hmaarrfk requested a review from Korijn as a code owner December 1, 2024 10:53
@hmaarrfk hmaarrfk force-pushed the two_versions_of_imgui branch 2 times, most recently from 2c85db4 to 459eacf Compare December 1, 2024 10:55
Comment thread wgpu/utils/imgui/imgui_renderer.py Outdated
@Korijn Korijn merged commit c5108ac into pygfx:main Dec 2, 2024
@hmaarrfk
Copy link
Copy Markdown
Contributor Author

hmaarrfk commented Dec 2, 2024

Thanks

hmaarrfk added a commit to hmaarrfk/pygfx that referenced this pull request Jan 27, 2025
Korijn added a commit to pygfx/pygfx that referenced this pull request Jan 27, 2025
* decrease minimum version of imgui-bundle

See pygfx/wgpu-py#649

* Test min python

---------

Co-authored-by: Korijn van Golen <korijn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants