Fix jupyter events#587
Merged
almarklein merged 3 commits intopygfx:mainfrom Sep 17, 2024
kushalkolar:fix-jupyter-events
Merged
Conversation
Korijn
approved these changes
Sep 17, 2024
Contributor
Author
|
any chance of a bugfix version soon? :) current release is broken with jupyter |
Member
Because of what this pr fixes, or something else? |
Member
|
Ah, I can reproduce it. Release on the way! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not necessary to redefine
_event_handlersinJupyterWgpuCanvassince it's already defined inWgpuAutoGui.wgpu-py/wgpu/gui/base.py
Lines 187 to 200 in b8c6335
The
_event_handlerschanged in #569 from a set to a list, this got caught in our CI: https://github.com/fastplotlib/fastplotlib/actions/runs/10834428342/job/30229322490#step:9:1185