Imgui multi canvas#539
Merged
Korijn merged 7 commits intopygfx:mainfrom Jul 29, 2024
kushalkolar:imgui-multi-canvas
Merged
Conversation
Contributor
|
I didn't consider the situation of multiple LGTM. |
kushalkolar
commented
Jul 15, 2024
Contributor
Author
No worries, your work on implementing imgui integration has been amazing! 😄 |
Korijn
reviewed
Jul 17, 2024
panxinmiao
approved these changes
Jul 29, 2024
Korijn
approved these changes
Jul 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes the context of
ImguiRendererso that it can be used for context switching. As far as I understand, this is required for rendering different UIs to multiple different canvases (added an example). Not sure if there's a better way to do this, welcome to suggestions! @panxinmiaotested in glfw & qt