More flexible linking controllers to cameras#778
Merged
almarklein merged 4 commits intomainfrom Jun 12, 2024
Merged
Conversation
Korijn
approved these changes
Jun 7, 2024
|
Thanks Almar! Good job! Addressing the camera drift is a very good point. I like this solution, I will try it out and if I am not able to make it work, I'll reach out again and ask you! |
23 tasks
This was referenced Jun 13, 2024
|
Hi Almar! |
Member
Author
|
Great! Thanks for the feedback! |
6 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #635
This provides a relatively simple solution to the problem outlined in #635, omitting the need for meta-controllers or two controllers modifying one camera.
x,yandzcamera states individually, instead of always settingposition.Some context: there are multiple levels at which a form of linking could have been implemented:
API changes
PerspectiveCamera.set_state()allows settingx,y, andz.Controller.add_camera()has new argsinclude_stateandexclude_state.