Skip to content

Inline _PyArg_NoKeywords from Python 3.13 in case it is missing#4269

Merged
illume merged 1 commit intopygame:python3.13from
hroncok:python3.13
Jun 19, 2024
Merged

Inline _PyArg_NoKeywords from Python 3.13 in case it is missing#4269
illume merged 1 commit intopygame:python3.13from
hroncok:python3.13

Conversation

@hroncok
Copy link
Copy Markdown
Contributor

@hroncok hroncok commented Jun 18, 2024

Python 3.13 made this private:
python/cpython#110966

Fixes #4099

@illume
Copy link
Copy Markdown
Member

illume commented Jun 19, 2024

Hi @hroncok,

thanks for this.

For fixing the formatting...

python3 -m pip install pre-commit
pre-commit install
pre-commit run -a

The python 3.6 builds are failing. I guess a version guard would be suitable.

/* python > 3.12 */
#if PY_VERSION_HEX > 0x030C0000
#ifndef _PyArg_NoKeywords

#endif
#endif

@hroncok
Copy link
Copy Markdown
Contributor Author

hroncok commented Jun 19, 2024

I won't be able to dedicate more time to this, sorry. Feel free to amend any changes necessary.

@illume illume changed the base branch from main to python3.13 June 19, 2024 17:00
Copy link
Copy Markdown
Member

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@illume illume merged commit f2cd999 into pygame:python3.13 Jun 19, 2024
@illume
Copy link
Copy Markdown
Member

illume commented Jun 19, 2024

Cool. Thanks again. I'll finish it off.

@illume illume mentioned this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to new C API for Python 3.13

2 participants