fix exec by papercuptech · Pull Request #140 · pyenv-win/pyenv-win

papercuptech · 2020-08-08T12:29:04Z

'exec' now handled directly in pyenv.bat
ExecCommand() in pyenv.vbs now uses WScript.Shell.exec()
rather than creating 'exec.bat'

'exec' now handled directly in pyenv.bat ExecCommand() in pyenv.vbs now uses WScript.Shell.exec() rather than creating 'exec.bat'

dedale · 2021-04-20T19:11:21Z

I tried to rebase this dev 😅, but according to all the tests I added, this breaks ❌ pyenv shell x.y.z use case, which depends on exec.bat. 😢
Idk yet how to circumvent this problem. ⌛ ❓

dedale · 2021-04-20T19:38:46Z

I tried to rebase this dev 😅, but according to all the tests I added, this breaks ❌ pyenv shell x.y.z use case, which depends on exec.bat. 😢
Idk yet how to circumvent this problem. ⌛ ❓

@kirankotari I think it also breaks Plugin feature

support 'shell' and plugins

'exec' now handled directly in pyenv.bat ExecCommand() in pyenv.vbs now uses WScript.Shell.exec() rather than creating 'exec.bat'

support 'shell' and plugins

dedale · 2021-04-21T06:13:31Z

Thanks @papercuptech, I think moving code to pyenv-shell.bat is the way to go.
To move on getting rid of exec.bat, I first need to add unit tests for pyenv shell and Plugin feature, then I'll rebase this PR.
I have already identified some impacts in the tests I have added.

papercuptech · 2021-04-21T12:15:38Z

I've been working on fixes for the shell command and for plugins.

I did move some logic to pyenv-shell.bat, but in order for the PYENV_VERSION var to be set correctly (and eliminate using exec.bat), vbs has to be avoided.

Regarding plugins, even before my fix they suffer from the same argument mangling problem I originally fixed for exec, which was fixed by avoiding going through any vbs code. I've now fixed this issue for plugins as well. Note, my previous fix did break plugins in a different way, but that regression has also now been fixed

I've also rebased my changes, and I'm now working to run the unit tests.

Will update things in a day or two.

support 'shell' and plugins remove 'shell', plugin, and '<cmd> --help' code from pyenv.vbs as theyre now handled directly in pyenv.bat

kirankotari · 2021-04-21T14:08:40Z

@papercuptech @dedale let me change the base branch, that might help.

papercuptech · 2021-04-21T14:19:57Z

Most tests passed. The first 2 in test_pyenv and all 4 in test_pyenv_feature_shell failed, but it looks to me like the problems are with the tests rather than what's being tested. My own "manual" testing indicates shell now works, plugins work, no exec.bat anywhere in sight. I attempted to debug tests, but not familiar with pytest and don't have the time atm to learn another test environment. Hopefully @dedale can address.

One "enhancement" is that plugins now run with PATH set just like it is with exec command; i.e. paths to "active" version of python.

ensure paths with spaces handled correctly by wrapping in ""

dedale · 2021-04-22T05:26:33Z

Great! You need to force Shell=false parameter where I call cmd.

dedale · 2021-04-23T20:01:37Z

Commit to fix tests: dedale@ced501a

kirankotari · 2021-04-23T20:42:01Z

Commit to fix tests: dedale@ced501a

@dedale are you able to push the changes to this PR?

dedale · 2021-04-23T20:47:58Z

Commit to fix tests: dedale@ced501a

@dedale are you able to push the changes to this PR?

I have created a PR to @papercuptech 's repo: papercuptech#1

fix shell tests

papercuptech · 2021-04-24T01:40:43Z

Merged @dedale changes into PR, but tests still failing..

dedale · 2021-04-24T06:20:27Z

Merged @dedale changes into PR, but tests still failing..

In Travis logs, pyenv.bat is getting -m argument. Did not reproduce on my laptop. I will investigate and use a temp PR to ensure tests pass in Travis.

ensure some version is active before running 'exec' reset local vars to support pyenv.bat reentry special case '.cmd' vs '.bat' plugins '.bat' can alter shell vars, but PATH not set to active version '.cmd' (and '.vbs') just the opposite

woops.. remove tab indents

remove erroneous 'echo %bindir%' exit when no active version

fix exec

5d8d32d

'exec' now handled directly in pyenv.bat ExecCommand() in pyenv.vbs now uses WScript.Shell.exec() rather than creating 'exec.bat'

papercuptech mentioned this pull request Aug 8, 2020

fix exec #139

Closed

kirankotari mentioned this pull request Oct 12, 2020

feature: replace the shims system with PATH magic #161

Closed

kirankotari self-requested a review January 30, 2021 02:45

kirankotari mentioned this pull request Mar 18, 2021

feature: Prepend To Path Option #213

Open

papercuptech added 4 commits April 21, 2021 01:13

fix exec

e93e15e

support 'shell' and plugins

fix exec

1c0a35c

'exec' now handled directly in pyenv.bat ExecCommand() in pyenv.vbs now uses WScript.Shell.exec() rather than creating 'exec.bat'

fix exec

7d4b439

support 'shell' and plugins

Merge remote-tracking branch 'origin/fix-exec' into fix-exec

a047807

fix exec

7f91135

support 'shell' and plugins remove 'shell', plugin, and '<cmd> --help' code from pyenv.vbs as theyre now handled directly in pyenv.bat

kirankotari changed the base branch from v1.2.5 to master April 21, 2021 14:08

fix exec

2cfb394

ensure paths with spaces handled correctly by wrapping in ""

fix shell tests

ced501a

Merge pull request #1 from dedale/pr140

d4d2eef

fix shell tests

dedale reviewed Apr 24, 2021

View reviewed changes

Comment thread pyenv-win/bin/pyenv.bat

Comment thread pyenv-win/bin/pyenv.bat

This was referenced Apr 24, 2021

Fix tests in #140 #237

Closed

fix shell tests ✔ papercuptech/pyenv-win#2

Closed

fix exec

f2e40b4

ensure some version is active before running 'exec' reset local vars to support pyenv.bat reentry special case '.cmd' vs '.bat' plugins '.bat' can alter shell vars, but PATH not set to active version '.cmd' (and '.vbs') just the opposite

fix exec

37fde7d

woops.. remove tab indents

dedale reviewed Apr 24, 2021

View reviewed changes

Comment thread pyenv-win/bin/pyenv.bat Outdated

dedale reviewed Apr 24, 2021

View reviewed changes

Comment thread pyenv-win/bin/pyenv.bat Outdated

fix exec

e9e3060

remove erroneous 'echo %bindir%' exit when no active version

dedale added the enhancement New feature or request label Apr 25, 2021

kirankotari approved these changes Apr 26, 2021

View reviewed changes

kirankotari merged commit 29000db into pyenv-win:master Apr 26, 2021

papercuptech mentioned this pull request Apr 27, 2021

Fix pyenv exec #244

Merged

Conversation

papercuptech commented Aug 8, 2020

Uh oh!

dedale commented Apr 20, 2021

Uh oh!

dedale commented Apr 20, 2021

Uh oh!

dedale commented Apr 21, 2021

Uh oh!

papercuptech commented Apr 21, 2021

Uh oh!

kirankotari commented Apr 21, 2021

Uh oh!

papercuptech commented Apr 21, 2021

Uh oh!

dedale commented Apr 22, 2021 via email • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dedale commented Apr 23, 2021

Uh oh!

kirankotari commented Apr 23, 2021

Uh oh!

dedale commented Apr 23, 2021

Uh oh!

papercuptech commented Apr 24, 2021

Uh oh!

dedale commented Apr 24, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dedale commented Apr 22, 2021 via email •

edited

Loading