attempt to run all twisted tests#7533
Merged
Merged
Conversation
Member
Author
|
@glyph has said he'll try to take a look at this this week. Will hold this draft open for a bit as a result. |
Contributor
|
On my mac, the test passes. Its OpenSSL:
On my ubuntu VM, it fails like CI does. Its OpenSSL:
Is this a bug that's been fixed somewhere between those versions? |
Contributor
|
The issue is that there is a too-short CA key that needs to be regenerated. The server PEM has a preamble attached to it but the stuff in |
Contributor
|
Tracking this on the Twisted side with twisted/twisted#10275 I guess |
Contributor
|
Potential fix here twisted/twisted#11608 |
reaperhulk
approved these changes
Aug 24, 2022
Member
Author
|
It's possible, I don't know how we'd test. It could also be patches one of
them carries.
…On Mon, Aug 22, 2022 at 8:45 PM Glyph ***@***.***> wrote:
On my mac, the test passes. Its OpenSSL:
OpenSSL 3.0.5 5 Jul 2022 (Library: OpenSSL 3.0.5 5 Jul 2022)
On my ubuntu VM, it fails like CI does. Its OpenSSL:
OpenSSL 3.0.2 15 Mar 2022 (Library: OpenSSL 3.0.2 15 Mar 2022)
Is this a bug that's been fixed somewhere between those versions?
—
Reply to this email directly, view it on GitHub
<#7533 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAGBFLTB6BPQMGIVOME3DV2QNLHANCNFSM57FFS7TQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
All that is necessary for evil to succeed is for good people to do nothing.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.