chore: normalize build tooling (nix CI, fail-fast scripts, fresh flake)#7
Merged
Conversation
Replace the inherited bower CI (no bower.json in this fork) with a nix-based one that runs scripts/build, scripts/test (if present) and luacheck; make the scripts fail-fast; refresh stale flake inputs.
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s Nix flake and GitHub Actions CI to standardize builds around a Nix-based dev environment, refresh flake inputs, and ensure CI runs the project’s build/lint steps (and tests when present).
Changes:
- Switch the flake dev shell from
easy-purescript-niximports topurescript-overlay-providedpurs/spagobinaries. - Add optional CI test execution (
./scripts/testwhen present) alongside the existing build andluachecksteps. - Refresh
flake.lockinputs and add flake-localnixConfigfor binary cache configuration.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
flake.nix |
Moves dev shell tooling to purescript-overlay and adds flake-local Nix cache configuration. |
flake.lock |
Refreshes/rewrites locked inputs to match the new flake input graph. |
.github/workflows/ci.yml |
Adds an optional test step and continues to run build + luacheck under nix develop. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+29
to
+32
| pslua.packages.${system}.default | ||
| purs-bin.purs-0_15_16 | ||
| spago-bin.spago-0_21_0 | ||
| treefmt |
Comment on lines
+38
to
+46
| nixConfig = { | ||
| extra-substituters = [ | ||
| "https://cache.iog.io" | ||
| "https://purescript-lua.cachix.org" | ||
| ]; | ||
| extra-trusted-public-keys = [ | ||
| "hydra.iohk.io:f/Ea+s+dFdN+3Y/G+FDgSq+a5NEWhJGzdjvKNGv0/EQ=" | ||
| "purescript-lua.cachix.org-1:yLs4ei2HtnuPtzLekOrW3xdfm95+Etw15gwgyIGTayA=" | ||
| ]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the inherited bower CI (no bower.json in this fork) with a nix-based one that runs scripts/build, scripts/test (if present) and luacheck; make the scripts fail-fast; refresh stale flake inputs.