Skip to content

fix: use bound argument n in Format.lua FFI instead of unbound number #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Unisay merged 2 commits into from
Jun 14, 2026
Merged

fix: use bound argument n in Format.lua FFI instead of unbound number #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c63dec6
fix: use bound argument n in Format.lua FFI instead of unbound number
Unisay Jun 14, 2026
61f141b
test: regression guard for Format.lua using the bound argument n
Unisay Jun 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions scripts/test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
#!/usr/bin/env bash
set -euo pipefail

echo "Running regression tests..."

lua test/regression/format.lua
6 changes: 3 additions & 3 deletions src/Data/Number/Format.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
return {
toPrecisionNative = (function(d) return function(n) return string.format("%." .. tostring(d) .. "f", number) end end),
toFixedNative = (function(d) return function(n) return string.format("%." .. tostring(d) .. "d", number) end end),
toExponentialNative = (function(d) return function(n) return string.format("%." .. tostring(d) .. "e", number) end end),
toPrecisionNative = (function(d) return function(n) return string.format("%." .. tostring(d) .. "f", n) end end),
toFixedNative = (function(d) return function(n) return string.format("%." .. tostring(d) .. "d", n) end end),
toExponentialNative = (function(d) return function(n) return string.format("%." .. tostring(d) .. "e", n) end end),
toString = (function(num) return tostring(num) end)
}
8 changes: 8 additions & 0 deletions test/regression/format.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
-- Regression guard: Format.lua must use its bound argument n, not an
-- unbound `number` global (nil at runtime, which made every formatter error).
local M = assert(dofile("src/Data/Number/Format.lua"))

assert(type(M.toPrecisionNative(6)(1234.56789)) == "string",
"toPrecisionNative must format its bound argument, not error on a nil global")

print("OK Format.lua uses the bound argument n")