chore: align CI to the hardened canon, add AGENTS.md#2
Merged
Conversation
CI: drop accept-flake-config, luacheck --std lua51 --no-unused-args (keeping --globals ngx), test via bash. Add AGENTS.md + CLAUDE.md. Bump pslua pin to current main. Tooling and docs only, no src/ change.
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s developer/agent documentation and aligns CI/linting with a hardened Nix CI configuration, while refreshing Nix flake input pins (notably the pslua/purescript-lua dependency) to newer revisions.
Changes:
- Harden CI by removing
accept-flake-config = true, switching luacheck to--std lua51 --no-unused-args, and running tests viabash ./scripts/test(when present). - Add agent guidance with
AGENTS.mdas the canonical instruction source andCLAUDE.mdas a one-line import. - Update
flake.lockto newer pinned inputs (including thepurescript-lua/psluapin).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
flake.lock |
Updates flake input pins, including the purescript-lua (pslua) revision and related Nix ecosystem inputs. |
CLAUDE.md |
Adds a one-line import pointing to AGENTS.md. |
AGENTS.md |
Adds canonical agent/dev instructions, including Lua 5.1 target notes and lint/build commands. |
.github/workflows/ci.yml |
Hardens Nix config usage and updates luacheck/test invocation to match Lua 5.1 + repo conventions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings ngx onto the hardened CI canon and adds the agent instructions.
CI (
.github/workflows/ci.yml):accept-flake-config = true(supply-chain risk; caches are already pinned inextra_nix_config).--std lua51 --no-unused-argsinstead of--std min, keeping--globals ngxfor the nginx global the FFI relies on.bash ./scripts/test.AGENTS.md+CLAUDE.md:AGENTS.mdis the single agent instruction file (its lint line keeps--globals ngx);CLAUDE.mdis a one-line@AGENTS.mdimport.Also bumps the pslua pin to current main (the #56/#49/#61 fixes). The fork's existing
treefmt.toml/lua-formatsetup is left as is.Tooling and docs only, no
src/change.Verification
nix develop -c ./scripts/buildwritesdist/Lua.Ngx*.luaand luacheck with--std lua51 --no-unused-args --globals ngx -- src/is clean locally.