chore: align build tooling (nix CI, fail-fast scripts)#1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns this fork to the canonical purescript-lua tooling.
What changed
Why the overlay (not a plain flake update)
A plain nix flake update on the previous easy-purescript-nix flake makes plain nix develop fail on insecure nodejs (nodejs-20.20.2 is marked insecure), which would force --impure. The overlay flake evaluates and builds with plain nix develop, no --impure.
ngx global in Luacheck
This is the OpenResty nginx-bindings fork: the FFI in src/Lua/Ngx.lua and src/Lua/Ngx/Http/Status.lua legitimately references the global ngx. The CI Luacheck step therefore allows it with --globals ngx. The target src/ is placed after a -- separator (luacheck --quiet --std min --globals ngx -- src/) because --globals is a multi-value option and would otherwise consume src/ as a global name rather than a file path.
Verification