fix: declare n local in Data.Int.toStringAs#2
Merged
Conversation
The loop variable `n` in `toStringAs` was assigned without `local`,
leaking a global and tripping luacheck ("setting non-standard global
variable n"). Adding `local` confines it to function scope and clears
the cascade of related warnings. No behaviour change.
Closes #1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1
Adds the missing
localtoninData.Int.toStringAs, which leaked a global and tripped luacheck (setting non-standard global variable n). Single-line, src-only change; no behaviour change. The remaining luacheck warnings in the file (math.pow, an unused argument) are pre-existing and unrelated, so they are left untouched to keep this fix minimal.