Skip to content

chore: normalize build tooling (nix CI, fail-fast scripts, fresh flake)#3

Closed
Unisay wants to merge 1 commit into
masterfrom
chore/normalize-tooling
Closed

chore: normalize build tooling (nix CI, fail-fast scripts, fresh flake)#3
Unisay wants to merge 1 commit into
masterfrom
chore/normalize-tooling

Conversation

@Unisay

@Unisay Unisay commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator

Replace the inherited bower CI (no bower.json in this fork) with a nix-based one that runs scripts/build, scripts/test (if present) and luacheck; make the scripts fail-fast; refresh stale flake inputs.

Replace the inherited bower CI (no bower.json in this fork) with a nix-based one that runs scripts/build, scripts/test (if present) and luacheck; make the scripts fail-fast; refresh stale flake inputs.
Unisay added a commit that referenced this pull request Jun 14, 2026
Follows the merged traverse fix (#2 by @Renegatto). On top of it:

- Fix mapWithIndexArray: it passed the 1-based Lua loop index to f, but
  PureScript mapWithIndex is 0-based, so f received i instead of i-1
  (originally reported in #1 by @sarahnya).
- Add a focused regression suite (test-regression/) run by scripts/test:
  traverse over Maybe is length/order-preserving at every size (>3 hits
  the pivot/append branch, which needs the Array Semigroup fix shipped in
  prelude v7.2.2), traverse over the Array applicative, and 0-based
  mapWithIndex.
- Align tooling: purescript-overlay dev shell on Lua 5.1 (drops easy-ps /
  insecure nodejs), canonical nix CI replacing the bower workflow,
  fail-fast scripts, and bump the package set to psc-0.15.15-20260614
  (prelude v7.2.2). Supersedes the earlier normalization PR #3.

Closes #1
@Unisay

Unisay commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded by #4, which includes this tooling normalization plus the mapWithIndex fix, the package-set bump to prelude v7.2.2, and a traverse/mapWithIndex regression suite. Closing in favor of #4.

@Unisay Unisay closed this Jun 14, 2026
@Unisay Unisay deleted the chore/normalize-tooling branch June 14, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant