-
Notifications
You must be signed in to change notification settings - Fork 20
Comparing changes
Open a pull request
base repository: purescript/purescript-effect
base: master
head repository: purescript-lua/purescript-lua-effect
compare: master
- 18 commits
- 26 files changed
- 3 contributors
Commits on Mar 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a2b460b - Browse repository at this point
Copy the full SHA a2b460bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ee3f598 - Browse repository at this point
Copy the full SHA ee3f598View commit details
Commits on Jun 14, 2026
-
fix: forward tenth argument in runEffectFn10
runEffectFn10 bound ten curried parameters a..j but only forwarded nine to the underlying function, silently dropping j (luacheck: unused argument j). Forward j so all ten declared arguments reach fn. Closes purescript-lua#1
Configuration menu - View commit details
-
Copy full SHA for 13ebb30 - Browse repository at this point
Copy the full SHA 13ebb30View commit details -
Configuration menu - View commit details
-
Copy full SHA for 04eb45a - Browse repository at this point
Copy the full SHA 04eb45aView commit details -
Merge pull request #2 from Unisay/fix/effect-runEffectFn10
fix: forward tenth argument in runEffectFn10
Configuration menu - View commit details
-
Copy full SHA for 6b96525 - Browse repository at this point
Copy the full SHA 6b96525View commit details -
Configuration menu - View commit details
-
Copy full SHA for bdff571 - Browse repository at this point
Copy the full SHA bdff571View commit details -
Configuration menu - View commit details
-
Copy full SHA for dedd6dd - Browse repository at this point
Copy the full SHA dedd6ddView commit details -
chore: harden CI per review (drop accept-flake-config, fail-fast scri…
…pts/build, run test via bash)
Configuration menu - View commit details
-
Copy full SHA for 6c89581 - Browse repository at this point
Copy the full SHA 6c89581View commit details -
Merge pull request #3 from Unisay/chore/align-overlay
chore: normalize build tooling + luacheck-clean FFI
Configuration menu - View commit details
-
Copy full SHA for b45a7ae - Browse repository at this point
Copy the full SHA b45a7aeView commit details -
chore: add AGENTS.md + CLAUDE.md, drop dead JavaScript-era files
AGENTS.md is the single instruction file the coding agents read natively; CLAUDE.md is a one-line @AGENTS.md import so Claude Code shares it. Also removes dead bower.json/package.json/.eslintrc.json. CI is already on the shared canon; no src/ change.
Configuration menu - View commit details
-
Copy full SHA for 0c0ed62 - Browse repository at this point
Copy the full SHA 0c0ed62View commit details -
Merge pull request #4 from Unisay/chore/agents-md-and-canon-ci
chore: add AGENTS.md, drop dead JavaScript-era files
Configuration menu - View commit details
-
Copy full SHA for 12904bf - Browse repository at this point
Copy the full SHA 12904bfView commit details -
chore: point pslua + package-set links at purescript-lua org
Repos moved from Unisay/* to the purescript-lua org. Update the pslua flake input and lockfile owner (same rev 94c13ce), the packages.dhall upstream-lua release URL, and the AGENTS.md links, so nothing relies on the old-owner redirect.
Configuration menu - View commit details
-
Copy full SHA for 8ffd2d5 - Browse repository at this point
Copy the full SHA 8ffd2d5View commit details -
Merge pull request #5 from purescript-lua/chore/migrate-org-links
chore: point pslua + package-set links at purescript-lua org
Configuration menu - View commit details
-
Copy full SHA for 24a6a04 - Browse repository at this point
Copy the full SHA 24a6a04View commit details -
chore: add treefmt formatting (nix fmt) and format the tree
Wire treefmt via treefmt-nix: nixfmt, dhall format, purs-tidy (.tidyrc.json) and LuaFormatter for the FFI (.lua-format, kept over StyLua because it preserves the parentheses pslua's parser needs). `nix fmt` formats; the dev shell installs a content-based pre-commit hook and CI runs `nix fmt && git diff --exit-code` (content-based, since the in-place formatters bump mtime and would trip treefmt --fail-on-change). Lua lines budget 130 cols, matching the raised `luacheck --max-line-length`. The bulk of the diff is the first format pass.
Configuration menu - View commit details
-
Copy full SHA for b217243 - Browse repository at this point
Copy the full SHA b217243View commit details -
Merge pull request #6 from purescript-lua/chore/treefmt
chore: add treefmt formatting (nix fmt + pre-commit + CI check)
Configuration menu - View commit details
-
Copy full SHA for 59ac8de - Browse repository at this point
Copy the full SHA 59ac8deView commit details
Commits on Jun 15, 2026
-
chore: harden pre-commit hook (tracked .githooks/ + core.hooksPath)
Replace the dev-shell installer that wrote .git/hooks/pre-commit with a tracked .githooks/pre-commit wired via `git config core.hooksPath .githooks`. Fixes three issues with the old hook: it gated on `[ -d .git ]` (false in worktrees/submodules where .git is a file), it clobbered any existing .git/hooks/pre-commit on every `nix develop`, and `nix fmt … || exit 0` swallowed real formatter failures. The new hook skips only when `nix` is absent (CI is the authoritative gate) and otherwise blocks on a `nix fmt` failure or reformat.
Configuration menu - View commit details
-
Copy full SHA for b39f9ad - Browse repository at this point
Copy the full SHA b39f9adView commit details -
chore: bump pslua dev input to 62e3653
Toolchain consistency: pin the pslua dev flake input to the current compiler main across the ecosystem. flake.lock only; the package set consumes sources + FFI, not this dev input, so no re-tag is needed.
Configuration menu - View commit details
-
Copy full SHA for 5c3fb38 - Browse repository at this point
Copy the full SHA 5c3fb38View commit details -
fix: forE iterates the half-open range [lo, hi)
PureScript/JS `forE lo hi f` runs over `[lo, hi)` — lo inclusive, hi exclusive (Effect.purs doc + JS `for (i = lo; i < hi; i++)`). Lua's numeric `for i = lo, hi` is inclusive of the upper bound, so the port ran one extra iteration at i = hi and never produced an empty range (`forE n n` ran once instead of zero times). Use `for i = lo, hi - 1`. Adds a Lua 5.1 regression guard (test/regression/effect.lua). Fixes purescript-lua/purescript-lua#78
Configuration menu - View commit details
-
Copy full SHA for 82bac3d - Browse repository at this point
Copy the full SHA 82bac3dView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...master