Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: purescript/purescript-effect
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a192ddb
Choose a base ref
...
head repository: purescript-lua/purescript-lua-effect
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 82bac3d
Choose a head ref
  • 18 commits
  • 26 files changed
  • 3 contributors

Commits on Mar 29, 2024

  1. Initial commit

    Unisay committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    a2b460b View commit details
    Browse the repository at this point in the history
  2. wrapped foreigns

    Unisay committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    ee3f598 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2026

  1. fix: forward tenth argument in runEffectFn10

    runEffectFn10 bound ten curried parameters a..j but only forwarded
    nine to the underlying function, silently dropping j (luacheck:
    unused argument j). Forward j so all ten declared arguments reach fn.
    
    Closes purescript-lua#1
    Unisay committed Jun 14, 2026
    Configuration menu
    Copy the full SHA
    13ebb30 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    04eb45a View commit details
    Browse the repository at this point in the history
  3. Merge pull request #2 from Unisay/fix/effect-runEffectFn10

    fix: forward tenth argument in runEffectFn10
    Unisay authored Jun 14, 2026
    Configuration menu
    Copy the full SHA
    6b96525 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bdff571 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    dedd6dd View commit details
    Browse the repository at this point in the history
  6. chore: harden CI per review (drop accept-flake-config, fail-fast scri…

    …pts/build, run test via bash)
    Unisay committed Jun 14, 2026
    Configuration menu
    Copy the full SHA
    6c89581 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #3 from Unisay/chore/align-overlay

    chore: normalize build tooling + luacheck-clean FFI
    Unisay authored Jun 14, 2026
    Configuration menu
    Copy the full SHA
    b45a7ae View commit details
    Browse the repository at this point in the history
  8. chore: add AGENTS.md + CLAUDE.md, drop dead JavaScript-era files

    AGENTS.md is the single instruction file the coding agents read natively;
    CLAUDE.md is a one-line @AGENTS.md import so Claude Code shares it. Also
    removes dead bower.json/package.json/.eslintrc.json. CI is already on the
    shared canon; no src/ change.
    Unisay committed Jun 14, 2026
    Configuration menu
    Copy the full SHA
    0c0ed62 View commit details
    Browse the repository at this point in the history
  9. Merge pull request #4 from Unisay/chore/agents-md-and-canon-ci

    chore: add AGENTS.md, drop dead JavaScript-era files
    Unisay authored Jun 14, 2026
    Configuration menu
    Copy the full SHA
    12904bf View commit details
    Browse the repository at this point in the history
  10. chore: point pslua + package-set links at purescript-lua org

    Repos moved from Unisay/* to the purescript-lua org. Update the pslua
    flake input and lockfile owner (same rev 94c13ce), the packages.dhall
    upstream-lua release URL, and the AGENTS.md links, so nothing relies on
    the old-owner redirect.
    Unisay committed Jun 14, 2026
    Configuration menu
    Copy the full SHA
    8ffd2d5 View commit details
    Browse the repository at this point in the history
  11. Merge pull request #5 from purescript-lua/chore/migrate-org-links

    chore: point pslua + package-set links at purescript-lua org
    Unisay authored Jun 14, 2026
    Configuration menu
    Copy the full SHA
    24a6a04 View commit details
    Browse the repository at this point in the history
  12. chore: add treefmt formatting (nix fmt) and format the tree

    Wire treefmt via treefmt-nix: nixfmt, dhall format, purs-tidy (.tidyrc.json)
    and LuaFormatter for the FFI (.lua-format, kept over StyLua because it
    preserves the parentheses pslua's parser needs). `nix fmt` formats; the dev
    shell installs a content-based pre-commit hook and CI runs
    `nix fmt && git diff --exit-code` (content-based, since the in-place
    formatters bump mtime and would trip treefmt --fail-on-change). Lua lines
    budget 130 cols, matching the raised `luacheck --max-line-length`. The bulk
    of the diff is the first format pass.
    Unisay committed Jun 14, 2026
    Configuration menu
    Copy the full SHA
    b217243 View commit details
    Browse the repository at this point in the history
  13. Merge pull request #6 from purescript-lua/chore/treefmt

    chore: add treefmt formatting (nix fmt + pre-commit + CI check)
    Unisay authored Jun 14, 2026
    Configuration menu
    Copy the full SHA
    59ac8de View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2026

  1. chore: harden pre-commit hook (tracked .githooks/ + core.hooksPath)

    Replace the dev-shell installer that wrote .git/hooks/pre-commit with a
    tracked .githooks/pre-commit wired via `git config core.hooksPath .githooks`.
    
    Fixes three issues with the old hook: it gated on `[ -d .git ]` (false in
    worktrees/submodules where .git is a file), it clobbered any existing
    .git/hooks/pre-commit on every `nix develop`, and `nix fmt … || exit 0`
    swallowed real formatter failures. The new hook skips only when `nix` is
    absent (CI is the authoritative gate) and otherwise blocks on a `nix fmt`
    failure or reformat.
    Unisay committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    b39f9ad View commit details
    Browse the repository at this point in the history
  2. chore: bump pslua dev input to 62e3653

    Toolchain consistency: pin the pslua dev flake input to the current
    compiler main across the ecosystem. flake.lock only; the package set
    consumes sources + FFI, not this dev input, so no re-tag is needed.
    Unisay committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    5c3fb38 View commit details
    Browse the repository at this point in the history
  3. fix: forE iterates the half-open range [lo, hi)

    PureScript/JS `forE lo hi f` runs over `[lo, hi)` — lo inclusive, hi
    exclusive (Effect.purs doc + JS `for (i = lo; i < hi; i++)`). Lua's
    numeric `for i = lo, hi` is inclusive of the upper bound, so the port ran
    one extra iteration at i = hi and never produced an empty range
    (`forE n n` ran once instead of zero times). Use `for i = lo, hi - 1`.
    
    Adds a Lua 5.1 regression guard (test/regression/effect.lua).
    
    Fixes purescript-lua/purescript-lua#78
    Unisay committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    82bac3d View commit details
    Browse the repository at this point in the history
Loading