Skip to content

fix: create the parent directory of --lua-output-file #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Unisay merged 1 commit into from
Jun 14, 2026
Merged

fix: create the parent directory of --lua-output-file #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions exe/Main.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import Language.PureScript.Backend qualified as Backend
import Language.PureScript.Backend.IR qualified as IR
import Language.PureScript.Backend.Lua qualified as Lua
import Language.PureScript.Backend.Lua.Printer qualified as Printer
import Language.PureScript.Backend.Output (withOutputFile)
import Language.PureScript.CoreFn.Reader qualified as CoreFn
import Language.PureScript.Names (runIdent, runModuleName)
import Main.Utf8 qualified as Utf8
Expand Down Expand Up @@ -53,19 +54,19 @@ main = Utf8.withUtf8 do
& Oops.runOops

let outputFile = toFilePath luaOutput
withFile outputFile WriteMode \h →
withOutputFile luaOutput \h →
renderIO h . layoutPretty defaultLayoutOptions $
Printer.printLuaChunk lua

when (OutputIR `elem` extraOutputs) do
irOutputFile ← toFilePath <$> replaceExtension ".ir" luaOutput
withFile irOutputFile WriteMode (`pHPrint` ir)
putTextLn $ "Wrote IR to " <> toText irOutputFile
irOutputPath ← replaceExtension ".ir" luaOutput
withOutputFile irOutputPath (`pHPrint` ir)
putTextLn $ "Wrote IR to " <> toText (toFilePath irOutputPath)

when (OutputLuaAst `elem` extraOutputs) do
luaAstOutputFile ← toFilePath <$> replaceExtension ".lua-ast" luaOutput
withFile luaAstOutputFile WriteMode (`pHPrint` lua)
putTextLn $ "Wrote Lua AST to " <> toText luaAstOutputFile
luaAstOutputPath ← replaceExtension ".lua-ast" luaOutput
withOutputFile luaAstOutputPath (`pHPrint` lua)
putTextLn $ "Wrote Lua AST to " <> toText (toFilePath luaAstOutputPath)

putTextLn $ "Wrote linked modules to " <> toText outputFile

Expand Down
20 changes: 20 additions & 0 deletions lib/Language/PureScript/Backend/Output.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
module Language.PureScript.Backend.Output
( withOutputFile
) where

import Path (Abs, File, Path, parent, toFilePath)
import Path.IO (ensureDir)

--------------------------------------------------------------------------------
-- Output ----------------------------------------------------------------------

{- | Open a file for writing, first creating its parent directory (and any
missing ancestors). pslua's @--lua-output-file@ may point into a directory
that does not exist yet (a gitignored @dist/@, say); plain 'withFile' would
abort with @does not exist@, a sharp edge each fork's build script would
otherwise work around with @mkdir -p@.
-}
withOutputFile ∷ Path Abs File → (Handle → IO r) → IO r
withOutputFile path action = do
ensureDir (parent path)
withFile (toFilePath path) WriteMode action
2 changes: 2 additions & 0 deletions pslua.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ library
Language.PureScript.Backend.Lua.Printer
Language.PureScript.Backend.Lua.Traversal
Language.PureScript.Backend.Lua.Types
Language.PureScript.Backend.Output
Language.PureScript.Backend.Types
Language.PureScript.Comments
Language.PureScript.CoreFn
Expand Down Expand Up @@ -172,6 +173,7 @@ test-suite spec
Language.PureScript.Backend.Lua.Linker.Foreign.Spec
Language.PureScript.Backend.Lua.Optimizer.Spec
Language.PureScript.Backend.Lua.Printer.Spec
Language.PureScript.Backend.Output.Spec
Test.Hspec.Expectations.Pretty
Test.Hspec.Extra
Test.Hspec.Golden
Expand Down
14 changes: 14 additions & 0 deletions test/Language/PureScript/Backend/Output/Spec.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
module Language.PureScript.Backend.Output.Spec (spec) where

import Language.PureScript.Backend.Output (withOutputFile)
import Path (parseRelFile, (</>))
import Path.IO (doesFileExist, withSystemTempDir)
import Test.Hspec (Spec, describe, it, shouldReturn)

spec ∷ Spec
spec = describe "Language.PureScript.Backend.Output" do
it "withOutputFile creates the missing parent directory" do
withSystemTempDir "pslua-output" \tmp → do
file ← (tmp </>) <$> parseRelFile "nested/dir/out.lua"
withOutputFile file (const pass)
doesFileExist file `shouldReturn` True
2 changes: 2 additions & 0 deletions test/Main.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import Language.PureScript.Backend.Lua.Golden.Spec qualified as Golden
import Language.PureScript.Backend.Lua.Linker.Foreign.Spec qualified as LuaLinkerForeign
import Language.PureScript.Backend.Lua.Optimizer.Spec qualified as LuaOptimizer
import Language.PureScript.Backend.Lua.Printer.Spec qualified as Printer
import Language.PureScript.Backend.Output.Spec qualified as Output
import Test.Hspec (hspec)

main ∷ IO ()
Expand All @@ -26,3 +27,4 @@ main = hspec do
LuaOptimizer.spec
Printer.spec
LuaLinkerForeign.spec
Output.spec
Loading