Scope Data.Int.toStringAs floor assignment to local during foreign import parsing#53
Closed
Copilot wants to merge 3 commits into
Closed
Scope Data.Int.toStringAs floor assignment to local during foreign import parsing#53Copilot wants to merge 3 commits into
Data.Int.toStringAs floor assignment to local during foreign import parsing#53Copilot wants to merge 3 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix global n leak in Int.toStringAs function
Scope Jun 14, 2026
Data.Int.toStringAs floor assignment to local during foreign import parsing
Collaborator
|
The issue was a one-line fix, but it should have been done it the other repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data.Int.toStringAsin the upstream Lua FFI can emitn = floor(i), which writes a global and leaks mutable shared state. This change ensures the imported foreign source is normalized to local scope for that assignment in the knowntoStringAsshape.Foreign import patching (targeted)
Language.PureScript.Backend.Lua.Linker.Foreign.parseForeignSourceto post-process parsed exports.toStringAs, when the value matches the expectedData.Intcontext (math.floor,table.insert,return function(i)), rewrite the specific assignmentn = floor(i)tolocal n = floor(i).Regression coverage
Language.PureScript.Backend.Lua.Linker.Foreign.Specfixture with atoStringAsexport containing the leaking assignment.