test: fix two GHC warnings in optimizer/CPR specs - #289
Merged
Conversation
Data.Text was imported qualified in Cpr/Spec.hs but never used. chainSite in the #221 growth-bound test lacked a type signature, tripping -Wmissing-local-signatures on its inferred polymorphic type; pinning it to Exp -> Int -> Exp (its only call site folds over [1 .. 16 :: Int]) resolves it.
Collaborator
Author
|
CI hasn't run yet — GitHub Actions is currently reporting a partial outage (status.githubstatus.com), not a repo-side issue. Will merge once CI comes back green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up spotted while working on #288: tricorder's GHCi session surfaces two warnings that cabal's flag set doesn't (so CI stayed green), but they're worth fixing anyway per the project's no-tolerated-warnings policy.
What
test/Language/PureScript/Backend/IR/Cpr/Spec.hs: removes the qualifiedData.Textimport, unused since some earlier edit.test/Language/PureScript/Backend/IR/Optimizer/Spec.hs: adds a type signature tochainSite(the local helper in the Bound call-site inlining growth on non-collapsing monad chains #221 growth-bound tests), silencing-Wmissing-local-signatureson its inferredExp -> Int -> Exp.Both are mechanical; no behavior or golden output changes.
Copilot review request skipped — quota's spent till end of month.