Store parent node in render #802#820
Store parent node in render #802#820roryc89 wants to merge 4 commits intopurescript-halogen:masterfrom
Conversation
|
I am very interested in this! I don't have time to check it out right now, but will as soon as I can. I've periodically worked on this without much luck, but a lot of that time was spent trying to isolate exactly what was happening since I had no concrete hypothesis for what was causing the issue. |
|
Ah thanks, that wasn't anything to do with you, it was unhappily formatted in |
|
I see that |
|
I was having a bug where a component with just a child component was causing new child component placed underneath each other (old child was not removed). I tried this patch and it's still problematic, instead of the child component placed directly underneath it's now placed before the end of the body tag |
I believe this may fix #802, #766 and #657. I have tested this on a similar problem I had with higher order components that had render branches that only rendered a single child component with no wrapping elements.
It seemed to have buggy behaviour when
substInParentwas passedNothingfor the parent node. To fix this I added the last found parent node to theRenderState