Extras for the PS 0.15 release#791
Merged
thomashoneyman merged 2 commits intoApr 29, 2022
Merged
Conversation
Member
|
I think it's OK to move it to be a |
thomashoneyman
approved these changes
Apr 29, 2022
Member
|
I've added this as a sum type: purescript-halogen/purescript-dom-indexed#29 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #785
I think #749 is worth looking at too perhaps (mostly needs changing in dom-indexed). As much as I dislike the idea of stringly typing, the context-based behaviour of the values that can be provided here suggests that maybe a more precise modelling isn't much use anyway. I don't know... it might still be nice to enumerate the many various options in a type anyway, since at least then it prevents typos / allows discovery by editor autocomplete, etc. What do you think @thomashoneyman?