Prevent done from running multiple times for subscriptions#448
Merged
natefaubion merged 1 commit intoApr 24, 2017
Merged
Conversation
63b7ccd to
e1bbff1
Compare
kritzcreek
reviewed
Apr 21, 2017
| done' = do | ||
| subs <- liftEff $ readRef subscriptions | ||
| when (maybe false (M.member i) subs) do | ||
| pure unit |
Member
Author
There was a problem hiding this comment.
Quick! Look over there! waves hands
What seems odd? 😉
e1bbff1 to
78675fb
Compare
Member
Author
|
@natefaubion unfortunately this does not fix whatever is going on with the "leaking" subscription in SlamData. I'm still trying to figure out what's happening in that case, as I can't see how Halogen would let it happen. |
natefaubion
approved these changes
Apr 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #418