Ensure getChildren returns an array#45
Merged
Merged
Conversation
paf31
added a commit
that referenced
this pull request
Sep 24, 2015
Ensure getChildren returns an array
Contributor
|
👍 Thanks! |
Contributor
Author
|
Thank you! On Thursday, September 24, 2015, Phil Freeman notifications@github.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #44
When a single element is provided as a child to the
createElementcall,getChildrenwould return a non-array element. This PR ensures that an array is returned in all cases by constructing a result array using theReact.Childrenbuild-in functions.