Skip to content

Prepare for 2.0 release#8

Merged
garyb merged 2 commits into
masterfrom
bump
Oct 7, 2016
Merged

Prepare for 2.0 release#8
garyb merged 2 commits into
masterfrom
bump

Conversation

@garyb
Copy link
Copy Markdown
Member

@garyb garyb commented Oct 2, 2016

Resolves #7

@paf31
Copy link
Copy Markdown
Contributor

paf31 commented Oct 2, 2016

👍 LGTM

@garyb
Copy link
Copy Markdown
Member Author

garyb commented Oct 2, 2016

I wondered if there was some trick we could use here to avoid the need for two versions of V, so you could choose which strategy (semiring or semigroup) to use via newtype or something, but I don't know if it's worth it?

@paf31
Copy link
Copy Markdown
Contributor

paf31 commented Oct 2, 2016

I'd be happy to unify the two. I think a solution is to use the Semiring version and make a type synonym (and helper functions) in another module for V (Additive s).

@paf31
Copy link
Copy Markdown
Contributor

paf31 commented Oct 7, 2016

👍

@garyb garyb merged commit 53de92d into master Oct 7, 2016
@garyb garyb deleted the bump branch October 7, 2016 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants