Update/0.12#42
Merged
Merged
Conversation
65 tasks
garyb
reviewed
Apr 26, 2018
Member
garyb
left a comment
There was a problem hiding this comment.
We could update everything in the ST module to drop the STRecord prefix too, like we've done in a few other places, since it can be handled nicely with qualification anyway.
| pureSTRecord :: forall r. (forall h eff. Eff (st :: ST h | eff) (STRecord h r)) -> Record r | ||
| pureSTRecord st = runPure (runSTRecord st) | ||
| runSTRecord :: forall r. (forall h. ST h (STRecord h r)) -> Record r | ||
| runSTRecord st = run (st >>= freezeSTRecord) |
Member
There was a problem hiding this comment.
Maybe this doesn't even need to exist anymore?
Member
Author
|
@garyb I agreed with and have made the changes you mentioned 😺 |
garyb
approved these changes
Apr 28, 2018
Member
garyb
left a comment
There was a problem hiding this comment.
Sorry, forgot this one was pending :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does this business with
runSTRecordandpureSTRecordlook right?