Skip to content

Remove incorrect newtype deriving in docs#33

Merged
thomashoneyman merged 2 commits into
purescript:masterfrom
pete-murphy:patch-1
Sep 3, 2022
Merged

Remove incorrect newtype deriving in docs#33
thomashoneyman merged 2 commits into
purescript:masterfrom
pete-murphy:patch-1

Conversation

@pete-murphy
Copy link
Copy Markdown
Contributor

@pete-murphy pete-murphy commented Sep 3, 2022

Description of the change

The code snippet in the over2 documentation doesn't compile

newtype Meter = Meter Int
derive newtype instance newtypeMeter :: Newtype Meter _
newtype SquareMeter = SquareMeter Int
derive newtype instance newtypeSquareMeter :: Newtype SquareMeter _

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@pete-murphy pete-murphy marked this pull request as ready for review September 3, 2022 22:19
Copy link
Copy Markdown
Member

@garyb garyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted 👍

@thomashoneyman thomashoneyman merged commit 0a0563e into purescript:master Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants