Skip to content

Reorder Inject instances to allow inj :: f ~> f#19

Merged
garyb merged 2 commits into
masterfrom
inj-reflexive
Nov 30, 2018
Merged

Reorder Inject instances to allow inj :: f ~> f#19
garyb merged 2 commits into
masterfrom
inj-reflexive

Conversation

@garyb
Copy link
Copy Markdown
Member

@garyb garyb commented Nov 30, 2018

Same as with the Either case 😉

@garyb garyb requested a review from hdgarrood November 30, 2018 13:15
@hdgarrood
Copy link
Copy Markdown
Contributor

Seems reasonable; presumably it would make sense to add a test too?

Copy link
Copy Markdown
Contributor

@hdgarrood hdgarrood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave it up to you re: tests

@garyb
Copy link
Copy Markdown
Member Author

garyb commented Nov 30, 2018

Thanks for checking!

@garyb garyb merged commit 96bcf8a into master Nov 30, 2018
@garyb garyb deleted the inj-reflexive branch November 30, 2018 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants