Change types in traverseArrayImpl to be more truthful#142
Merged
thomashoneyman merged 1 commit intoMar 10, 2022
Merged
Conversation
Contributor
Author
Does this change require an addition to the changelog? While changing the type of |
thomashoneyman
approved these changes
Oct 26, 2021
Member
thomashoneyman
left a comment
There was a problem hiding this comment.
@cdepillabout I think you're right about the changes wrt other backends, and I'm on board.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR changes the types of
traverseArrayImplto be more true to how they are actually used.This changes
traverseArrayImplfromto
traverseArrayImplis called like the following:Here the
apply,map, andpurefunctions are all polymorphic in their arguments (thexandyin the changed type above), so this new type fortraverseArrayImplis more true.Also, in the FFI files for
traverseArrayImpl,apply,map, andpureare used as if they are polymorphic. For instance,pureis used on anArray, not ana:purescript-foldable-traversable/src/Data/Traversable.js
Line 37 in d581caf
Checklist: